linux-kernel - Re: [PATCH V3] clk: imx8m: fix bus critical clk registration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201103105924.GD31601@dragon>
Date:   Tue, 3 Nov 2020 18:59:25 +0800
From:   Shawn Guo <shawnguo@...nel.org>
To:     Peng Fan <peng.fan@....com>, Stephen Boyd <sboyd@...nel.org>
Cc:     "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "festevam@...il.com" <festevam@...il.com>,
        Abel Vesa <abel.vesa@....com>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        dl-linux-imx <linux-imx@....com>,
        Anson Huang <anson.huang@....com>,
        "linux-clk@...r.kernel.org" <linux-clk@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Aisheng Dong <aisheng.dong@....com>
Subject: Re: [PATCH V3] clk: imx8m: fix bus critical clk registration

On Tue, Nov 03, 2020 at 01:03:44AM +0000, Peng Fan wrote:
> Shawn,
> 
> > Subject: Re: [PATCH V3] clk: imx8m: fix bus critical clk registration
> > 
> > On Sun, Nov 01, 2020 at 07:23:54PM +0800, peng.fan@....com wrote:
> > > From: Peng Fan <peng.fan@....com>
> > >
> > > noc/axi/ahb are bus clk, not peripheral clk.
> > > Since peripheral clk has a limitation that for peripheral clock slice,
> > > IP clock slices must be stopped to change the clock source.
> > >
> > > However if the bus clk is marked as critical clk peripheral, the
> > > assigned clock parent operation will fail.
> > >
> > > So we added CLK_SET_PARENT_GATE flag to avoid glitch.
> > >
> > > And add imx8m_clk_hw_composite_bus_critical for bus critical clock
> > > usage
> > >
> > > Fixes: 936c383673b9e ("clk: imx: fix composite peripheral flags")
> > > Reviewed-by: Abel Vesa <abel.vesa@....com>
> > > Reported-by: Abel Vesa <abel.vesa@....com>
> > > Signed-off-by: Peng Fan <peng.fan@....com>
> > 
> > Do you want this be picked up as a fix for 5.10-rc or non-critical stuff for
> > -next?
> 
> Please take this as a fix for 5.10-rc.

Okay, I will leave this to Stephen then.

Shawn