linux-kernel - Re: [PATCH] fsl/fman: add missing put_devcie() call in fman_port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cf2e0c7c-ba3e-b04f-488d-4dd0fcb81f7a@huawei.com>
Date:   Tue, 3 Nov 2020 19:09:02 +0800
From:   "yukuai (C)" <yukuai3@...wei.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     <madalin.bucur@....com>, <davem@...emloft.net>,
        <florinel.iordache@....com>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <yi.zhang@...wei.com>
Subject: Re: [PATCH] fsl/fman: add missing put_devcie() call in
 fman_port_probe()


On 2020/11/03 9:30, Jakub Kicinski wrote:
> On Sat, 31 Oct 2020 18:54:18 +0800 Yu Kuai wrote:
>> if of_find_device_by_node() succeed, fman_port_probe() doesn't have a
>> corresponding put_device(). Thus add jump target to fix the exception
>> handling for this function implementation.
>>
>> Fixes: 0572054617f3 ("fsl/fman: fix dereference null return value")
>> Signed-off-by: Yu Kuai <yukuai3@...wei.com>
> 
>> diff --git a/drivers/net/ethernet/freescale/fman/fman_port.c b/drivers/net/ethernet/freescale/fman/fman_port.c
>> index d9baac0dbc7d..576ce6df3fce 100644
>> --- a/drivers/net/ethernet/freescale/fman/fman_port.c
>> +++ b/drivers/net/ethernet/freescale/fman/fman_port.c
>> @@ -1799,13 +1799,13 @@ static int fman_port_probe(struct platform_device *of_dev)
>>   	of_node_put(fm_node);
>>   	if (!fm_pdev) {
>>   		err = -EINVAL;
>> -		goto return_err;
>> +		goto put_device;
>>   	}
> 
>> @@ -1898,6 +1898,8 @@ static int fman_port_probe(struct platform_device *of_dev)
>>   
>>   return_err:
>>   	of_node_put(port_node);
>> +put_device:
>> +	put_device(&fm_pdev->dev);
>>   free_port:
>>   	kfree(port);
>>   	return err;
> 
> This does not look right. You're jumping to put_device() when fm_pdev
> is NULL?
> 
Hi,

oops, it's a silly mistake. Will fix it in V2 patch.

Thanks,
Yu Kuai

> The order of error handling should be the reverse of the order of
> execution of the function.
> .
>