linux-kernel - Re: [PATCH v2] mtd:ubi: Remove useless code in bytes_str_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFLxGvwKTezooPvWQDZViaXsZ6zsbgf6b-O8RtcU9x6w27xYpQ@mail.gmail.com>
Date:   Tue, 3 Nov 2020 13:34:51 +0100
From:   Richard Weinberger <richard.weinberger@...il.com>
To:     Chengsong Ke <kechengsong@...wei.com>
Cc:     Richard Weinberger <richard@....at>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        linux-mtd@...ts.infradead.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] mtd:ubi: Remove useless code in bytes_str_to_int

On Tue, Nov 3, 2020 at 1:00 PM Chengsong Ke <kechengsong@...wei.com> wrote:
>
> From: k00524021 <kechengsong@...wei.com>
>
> As a local variable, "endp" is neither refered nor returned
> after this line "endp += 2", it looks like a useless code,
> suggest to remove it.
>
> Signed-off-by: Chengsong Ke <kechengsong@...wei.com>
> ---
>  drivers/mtd/ubi/build.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/mtd/ubi/build.c b/drivers/mtd/ubi/build.c
> index e85b04e9716b..46a6dd75e533 100644
> --- a/drivers/mtd/ubi/build.c
> +++ b/drivers/mtd/ubi/build.c
> @@ -1351,8 +1351,6 @@ static int bytes_str_to_int(const char *str)
>                 fallthrough;
>         case 'K':
>                 result *= 1024;
> -               if (endp[1] == 'i' && endp[2] == 'B')
> -                       endp += 2;

Makes sense. But why did you send a v2?

-- 
Thanks,
//richard