linux-kernel - Re: [PATCH 09/12] net: ethernet: ibm: ibmvnic: Fix some kernel-doc misdemeanours

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <85bc60fb363b95bc87627607d20b3616@linux.vnet.ibm.com>
Date:   Wed, 04 Nov 2020 09:54:12 -0800
From:   drt <drt@...ux.vnet.ibm.com>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     Lee Jones <lee.jones@...aro.org>, davem@...emloft.net,
        kuba@...nel.org, Thomas Falcon <tlfalcon@...ux.vnet.ibm.com>,
        Michael Ellerman <mpe@...erman.id.au>,
        linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
        Santiago Leon <santi_leon@...oo.com>,
        John Allen <jallen@...ux.vnet.ibm.com>, netdev@...r.kernel.org,
        Lijun Pan <ljp@...ux.ibm.com>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Dany Madden <drt@...ux.ibm.com>,
        Paul Mackerras <paulus@...ba.org>,
        Sukadev Bhattiprolu <sukadev@...ux.ibm.com>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 09/12] net: ethernet: ibm: ibmvnic: Fix some kernel-doc
 misdemeanours

On 2020-11-04 05:38, Andrew Lunn wrote:
> On Wed, Nov 04, 2020 at 09:06:07AM +0000, Lee Jones wrote:
>> Fixes the following W=1 kernel build warning(s):
>> 
>>  from drivers/net/ethernet/ibm/ibmvnic.c:35:
>>  inlined from ‘handle_vpd_rsp’ at 
>> drivers/net/ethernet/ibm/ibmvnic.c:4124:3:
>>  drivers/net/ethernet/ibm/ibmvnic.c:1362: warning: Function parameter 
>> or member 'hdr_field' not described in 'build_hdr_data'
>>  drivers/net/ethernet/ibm/ibmvnic.c:1362: warning: Function parameter 
>> or member 'skb' not described in 'build_hdr_data'
>>  drivers/net/ethernet/ibm/ibmvnic.c:1362: warning: Function parameter 
>> or member 'hdr_len' not described in 'build_hdr_data'
>>  drivers/net/ethernet/ibm/ibmvnic.c:1362: warning: Function parameter 
>> or member 'hdr_data' not described in 'build_hdr_data'
>>  drivers/net/ethernet/ibm/ibmvnic.c:1423: warning: Function parameter 
>> or member 'hdr_field' not described in 'create_hdr_descs'
>>  drivers/net/ethernet/ibm/ibmvnic.c:1423: warning: Function parameter 
>> or member 'hdr_data' not described in 'create_hdr_descs'
>>  drivers/net/ethernet/ibm/ibmvnic.c:1423: warning: Function parameter 
>> or member 'len' not described in 'create_hdr_descs'
>>  drivers/net/ethernet/ibm/ibmvnic.c:1423: warning: Function parameter 
>> or member 'hdr_len' not described in 'create_hdr_descs'
>>  drivers/net/ethernet/ibm/ibmvnic.c:1423: warning: Function parameter 
>> or member 'scrq_arr' not described in 'create_hdr_descs'
>>  drivers/net/ethernet/ibm/ibmvnic.c:1474: warning: Function parameter 
>> or member 'txbuff' not described in 'build_hdr_descs_arr'
>>  drivers/net/ethernet/ibm/ibmvnic.c:1474: warning: Function parameter 
>> or member 'num_entries' not described in 'build_hdr_descs_arr'
>>  drivers/net/ethernet/ibm/ibmvnic.c:1474: warning: Function parameter 
>> or member 'hdr_field' not described in 'build_hdr_descs_arr'
>>  drivers/net/ethernet/ibm/ibmvnic.c:1832: warning: Function parameter 
>> or member 'adapter' not described in 'do_change_param_reset'
>>  drivers/net/ethernet/ibm/ibmvnic.c:1832: warning: Function parameter 
>> or member 'rwi' not described in 'do_change_param_reset'
>>  drivers/net/ethernet/ibm/ibmvnic.c:1832: warning: Function parameter 
>> or member 'reset_state' not described in 'do_change_param_reset'
>>  drivers/net/ethernet/ibm/ibmvnic.c:1911: warning: Function parameter 
>> or member 'adapter' not described in 'do_reset'
>>  drivers/net/ethernet/ibm/ibmvnic.c:1911: warning: Function parameter 
>> or member 'rwi' not described in 'do_reset'
>>  drivers/net/ethernet/ibm/ibmvnic.c:1911: warning: Function parameter 
>> or member 'reset_state' not described in 'do_reset'
>> 
>> Cc: Dany Madden <drt@...ux.ibm.com>
>> Cc: Lijun Pan <ljp@...ux.ibm.com>
>> Cc: Sukadev Bhattiprolu <sukadev@...ux.ibm.com>
>> Cc: Michael Ellerman <mpe@...erman.id.au>
>> Cc: Benjamin Herrenschmidt <benh@...nel.crashing.org>
>> Cc: Paul Mackerras <paulus@...ba.org>
>> Cc: "David S. Miller" <davem@...emloft.net>
>> Cc: Jakub Kicinski <kuba@...nel.org>
>> Cc: Santiago Leon <santi_leon@...oo.com>
>> Cc: Thomas Falcon <tlfalcon@...ux.vnet.ibm.com>
>> Cc: John Allen <jallen@...ux.vnet.ibm.com>
>> Cc: netdev@...r.kernel.org
>> Cc: linuxppc-dev@...ts.ozlabs.org
>> Signed-off-by: Lee Jones <lee.jones@...aro.org>
> 
> Reviewed-by: Andrew Lunn <andrew@...n.ch>

Reviewed-by: Dany Madden <drt@...ux.ibm.com>

Thanks, Lee.
Dany
> 
>     Andrew