linux-kernel - Re: [PATCH v2 5/6] ARM: dts: sun8i: s3: Add dts for the Elimo Initium SBC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201104190515.nppp633zkn2s4j73@gilmour.lan>
Date:   Wed, 4 Nov 2020 20:05:15 +0100
From:   Maxime Ripard <maxime@...no.tech>
To:     Matteo Scordino <matteo.scordino@...il.com>
Cc:     wens@...e.org, robh+dt@...nel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 5/6] ARM: dts: sun8i: s3: Add dts for the Elimo
 Initium SBC

On Tue, Nov 03, 2020 at 04:33:26PM +0000, Matteo Scordino wrote:
> > 
> > >  	sun8i-t3-cqa3t-bv3.dtb \
> > >  	sun8i-v3s-licheepi-zero.dtb \
> > >  	sun8i-v3s-licheepi-zero-dock.dtb \
> > > diff --git a/arch/arm/boot/dts/sun8i-s3-elimo-initium.dts b/arch/arm/boot/dts/sun8i-s3-elimo-initium.dts
> > > new file mode 100644
> > > index 000000000000..7677ddc07bf9
> > > --- /dev/null
> > > +++ b/arch/arm/boot/dts/sun8i-s3-elimo-initium.dts
> > > @@ -0,0 +1,28 @@
> > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> > > +/*
> > > + * Copyright (C) 2020 Matteo Scordino <matteo@...mo.io>
> > > + */
> > > +
> > > +/dts-v1/;
> > > +#include "sun8i-s3-elimo-impetus.dtsi"
> > > +
> > > +/ {
> > > +	model = "Elimo Initium";
> > > +	compatible = "elimo,initium", "elimo,impetus", "sochip,s3",
> > > +    "allwinner,sun8i-v3";
> > 
> > You should indent that properly
> 
> Double ouch. 
> However, how is a multiline dt property supposed to be indented? 
> I have tried a few combinations but nothing seemed to make checkpatch.pl happy,
> except leaving no space at all at the beginning of the line. But I think makes it
> quite unreadable?

We usually pad with tabs, then spaces to match the opening quotes, like

compatible = "elimo,initium", "elimo,impetus", "sochip,s3",
	     "allwinner,sun8i-v3";

Maxime

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)