linux-kernel - Re: [PATCH] selftests/exec: Fix building of exec test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202011041105.5A2D9D1F@keescook>
Date:   Wed, 4 Nov 2020 11:07:16 -0800
From:   Kees Cook <keescook@...omium.org>
To:     Michael Ellerman <mpe@...erman.id.au>
Cc:     linux-kselftest@...r.kernel.org, skhan@...uxfoundation.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] selftests/exec: Fix building of exec test

On Wed, Nov 04, 2020 at 09:07:06PM +1100, Michael Ellerman wrote:
> Currently the exec test does not build:
> 
>   make[1]: Entering directory '/linux/tools/testing/selftests/exec'
>   ...
>   make[1]: *** No rule to make target '/output/kselftest/exec/pipe', needed by 'all'.
> 
> This is because pipe is listed in TEST_GEN_FILES, but pipe is not
> generated by the Makefile, it's created at runtime. So drop pipe from
> TEST_GEN_FILES.

Ah, yes, shouldn't it be added to EXTRA_CLEAN though?

Fixes: 61016db15b8e ("selftests/exec: Verify execve of non-regular files fail")

> 
> With that fixed, then install fails:
> 
>   make[1]: Entering directory '/linux/tools/testing/selftests/exec'
>   rsync -a binfmt_script non-regular /output/install/exec/
>   rsync: link_stat "/linux/tools/testing/selftests/exec/non-regular" failed: No such file or directory (2)
> 
> That's because non-regular hasn't been built, because it's in
> TEST_PROGS, it should be part of TEST_GEN_PROGS to indicate that it
> needs to be built.

Yes, thanks again!

Fixes: 0f71241a8e32 ("selftests/exec: add file type errno tests")

for both:

Acked-by: Kees Cook <keescook@...omium.org>

-- 
Kees Cook