linux-kernel - [PATCH 04/36] tty: tty_io: Move 'tty_sysctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20201104193549.4026187-5-lee.jones@linaro.org>
Date:   Wed,  4 Nov 2020 19:35:17 +0000
From:   Lee Jones <lee.jones@...aro.org>
To:     lee.jones@...aro.org
Cc:     linux-kernel@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jirislaby@...nel.org>,
        Nick Holloway <alfie@....warwick.ac.uk>,
        -- <julian@...nix.uhcc.hawaii.edu>,
        Marko Kohtala <Marko.Kohtala@....fi>,
        Bill Hawes <whawes@...r.net>,
        "C. Scott Ananian" <cananian@...mni.princeton.edu>,
        Russell King <rmk@....linux.org.uk>,
        Andrew Morton <andrewm@....edu.eu>
Subject: [PATCH 04/36] tty: tty_io: Move 'tty_sysctl_init's prototype to shared space

Fixes the following W=1 kernel build warning(s):

 drivers/tty/tty_ldisc.c:883:6: warning: no previous prototype for ‘tty_sysctl_init’ [-Wmissing-prototypes]
 883 | void tty_sysctl_init(void)
 | ^~~~~~~~~~~~~~~

Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: Jiri Slaby <jirislaby@...nel.org>
Cc: Nick Holloway <alfie@....warwick.ac.uk>
Cc: -- <julian@...nix.uhcc.hawaii.edu>
Cc: Marko Kohtala <Marko.Kohtala@....fi>
Cc: Bill Hawes <whawes@...r.net>
Cc: "C. Scott Ananian" <cananian@...mni.princeton.edu>
Cc: Russell King <rmk@....linux.org.uk>
Cc: Andrew Morton <andrewm@....edu.eu>
Signed-off-by: Lee Jones <lee.jones@...aro.org>
---
 drivers/tty/tty_io.c | 2 --
 include/linux/tty.h  | 1 +
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/tty/tty_io.c b/drivers/tty/tty_io.c
index 7a4c02548fb3f..88b00c47b606e 100644
--- a/drivers/tty/tty_io.c
+++ b/drivers/tty/tty_io.c
@@ -514,8 +514,6 @@ static const struct file_operations hung_up_tty_fops = {
 static DEFINE_SPINLOCK(redirect_lock);
 static struct file *redirect;
 
-extern void tty_sysctl_init(void);
-
 /**
  *	tty_wakeup	-	request more data
  *	@tty: terminal
diff --git a/include/linux/tty.h b/include/linux/tty.h
index a99e9b8e4e316..10212c6e4345e 100644
--- a/include/linux/tty.h
+++ b/include/linux/tty.h
@@ -716,6 +716,7 @@ extern int __must_check tty_ldisc_init(struct tty_struct *tty);
 extern void tty_ldisc_deinit(struct tty_struct *tty);
 extern int tty_ldisc_receive_buf(struct tty_ldisc *ld, const unsigned char *p,
 				 char *f, int count);
+extern void tty_sysctl_init(void);
 
 /* n_tty.c */
 extern void n_tty_inherit_ops(struct tty_ldisc_ops *ops);
-- 
2.25.1