[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20201104202920.GC1796392@gmail.com>
Date: Wed, 4 Nov 2020 12:29:20 -0800
From: Eric Biggers <ebiggers@...nel.org>
To: Lokesh Gidra <lokeshgidra@...gle.com>
Cc: Alexander Viro <viro@...iv.linux.org.uk>,
James Morris <jmorris@...ei.org>,
Stephen Smalley <stephen.smalley.work@...il.com>,
Casey Schaufler <casey@...aufler-ca.com>,
"Serge E. Hallyn" <serge@...lyn.com>,
Paul Moore <paul@...l-moore.com>,
Eric Paris <eparis@...isplace.org>,
Daniel Colascione <dancol@...col.org>,
Kees Cook <keescook@...omium.org>,
"Eric W. Biederman" <ebiederm@...ssion.com>,
KP Singh <kpsingh@...gle.com>,
David Howells <dhowells@...hat.com>,
Thomas Cedeno <thomascedeno@...gle.com>,
Anders Roxell <anders.roxell@...aro.org>,
Sami Tolvanen <samitolvanen@...gle.com>,
Matthew Garrett <matthewgarrett@...gle.com>,
Aaron Goidel <acgoide@...ho.nsa.gov>,
Randy Dunlap <rdunlap@...radead.org>,
"Joel Fernandes (Google)" <joel@...lfernandes.org>,
YueHaibing <yuehaibing@...wei.com>,
Christian Brauner <christian.brauner@...ntu.com>,
Alexei Starovoitov <ast@...nel.org>,
Alexey Budankov <alexey.budankov@...ux.intel.com>,
Adrian Reber <areber@...hat.com>,
Aleksa Sarai <cyphar@...har.com>,
linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-security-module@...r.kernel.org, selinux@...r.kernel.org,
kaleshsingh@...gle.com, calin@...gle.com, surenb@...gle.com,
nnk@...gle.com, jeffv@...gle.com, kernel-team@...roid.com
Subject: Re: [PATCH v10 0/3] SELinux support for anonymous inodes and UFFD
On Wed, Nov 04, 2020 at 12:07:16PM -0800, Eric Biggers wrote:
> On Sun, Oct 11, 2020 at 01:29:33AM -0700, Lokesh Gidra wrote:
> > Daniel Colascione (3):
> > Add a new LSM-supporting anonymous inode interface
> > Teach SELinux about anonymous inodes
> > Use secure anon inodes for userfaultfd
>
> Patches are supposed to have subsystem prefixes, e.g.
>
> fs, security: add a new LSM-supporting anonymous inode interface
> selinux: implement init_security_anon()
> userfaultfd: use secure anon inodes
>
> ... but that points to the fact that the first one is really both fs and
> security subsystem changes. Patches should be one logical change only. I
> suggest splitting it up into:
>
> security: add init_security_anon() LSM hook
> fs: add anon_inode_getfd_secure()
Correction: it's "inode_init_security_anon()", not "init_security_anon()".
- Eric
Powered by blists - more mailing lists