linux-kernel - Re: [PATCH] drm/mediatek: mtk_dpi: Fix unused variable 'mtk_dpi_encoder

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAAOTY__yPAph065cbgL8St5U4auW9H8mfWJrT67q5HVNiAmsBA@mail.gmail.com>
Date:   Thu, 5 Nov 2020 07:50:30 +0800
From:   Chun-Kuang Hu <chunkuang.hu@...nel.org>
To:     Enric Balletbo i Serra <enric.balletbo@...labora.com>
Cc:     linux-kernel <linux-kernel@...r.kernel.org>,
        Collabora Kernel ML <kernel@...labora.com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Nicolas Boichat <drinkcat@...omium.org>,
        Hsin-Yi Wang <hsinyi@...omium.org>,
        kernel test robot <lkp@...el.com>,
        Chun-Kuang Hu <chunkuang.hu@...nel.org>,
        Daniel Vetter <daniel@...ll.ch>,
        David Airlie <airlied@...ux.ie>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        DRI Development <dri-devel@...ts.freedesktop.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@...ts.infradead.org>
Subject: Re: [PATCH] drm/mediatek: mtk_dpi: Fix unused variable 'mtk_dpi_encoder_funcs'

Hi, Enric:

Enric Balletbo i Serra <enric.balletbo@...labora.com> 於 2020年11月4日 週三 下午6:40寫道：
>
> Hi
>
> On 5/10/20 18:22, Enric Balletbo i Serra wrote:
> > Commit f89c696e7f63 ("drm/mediatek: mtk_dpi: Convert to bridge driver")
> > introduced the following build warning with W=1
> >
> >  drivers/gpu/drm/mediatek/mtk_dpi.c:530:39: warning: unused variable 'mtk_dpi_encoder_funcs' [-Wunused-const-variable]
> >  static const struct drm_encoder_funcs mtk_dpi_encoder_funcs = {
> >
> > This struct is and the 'mtk_dpi_encoder_destroy()' are not needed
> > anymore, so remove them.
> >
> > Fixes: f89c696e7f63 ("drm/mediatek: mtk_dpi: Convert to bridge driver")
> > Reported-by: kernel test robot <lkp@...el.com>
> > Signed-off-by: Enric Balletbo i Serra <enric.balletbo@...labora.com>
> > ---
>
> A gentle ping on this small fix. Thanks,

Applied to mediatek-drm-fixes [1], thanks.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-fixes

Regards,
Chun-Kuang.

>
>   Enric
>
> >
> >  drivers/gpu/drm/mediatek/mtk_dpi.c | 9 ---------
> >  1 file changed, 9 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/drivers/gpu/drm/mediatek/mtk_dpi.c
> > index 589ef33a1780..2609d917e3f9 100644
> > --- a/drivers/gpu/drm/mediatek/mtk_dpi.c
> > +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c
> > @@ -522,15 +522,6 @@ static int mtk_dpi_set_display_mode(struct mtk_dpi *dpi,
> >       return 0;
> >  }
> >
> > -static void mtk_dpi_encoder_destroy(struct drm_encoder *encoder)
> > -{
> > -     drm_encoder_cleanup(encoder);
> > -}
> > -
> > -static const struct drm_encoder_funcs mtk_dpi_encoder_funcs = {
> > -     .destroy = mtk_dpi_encoder_destroy,
> > -};
> > -
> >  static int mtk_dpi_bridge_attach(struct drm_bridge *bridge,
> >                                enum drm_bridge_attach_flags flags)
> >  {
> >