lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Date:   Wed, 4 Nov 2020 14:48:02 +0800
From:   kernel test robot <lkp@...el.com>
To:     James Smart <jsmart2021@...il.com>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        Jens Axboe <axboe@...nel.dk>, Paul Ely <paul.ely@...adcom.com>,
        Hannes Reinecke <hare@...e.de>, Christoph Hellwig <hch@....de>
Subject: drivers/scsi/lpfc/lpfc_nvme.c:879:19: warning: variable 'phba' set
 but not used

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   4ef8451b332662d004df269d4cdeb7d9f31419b5
commit: e96a22b0b7c252295180c12128af380282e3b8c5 lpfc: Refactor Send LS Abort support
date:   6 months ago
config: x86_64-customedconfig-lck8195-cfld1 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
        # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=e96a22b0b7c252295180c12128af380282e3b8c5
        git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
        git fetch --no-tags linus master
        git checkout e96a22b0b7c252295180c12128af380282e3b8c5
        # save the attached .config to linux build tree
        make W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   drivers/scsi/lpfc/lpfc_nvme.c: In function 'lpfc_nvme_ls_abort':
>> drivers/scsi/lpfc/lpfc_nvme.c:879:19: warning: variable 'phba' set but not used [-Wunused-but-set-variable]
     879 |  struct lpfc_hba *phba;
         |                   ^~~~

vim +/phba +879 drivers/scsi/lpfc/lpfc_nvme.c

   862	
   863	/**
   864	 * lpfc_nvme_ls_abort - Abort a prior NVME LS request
   865	 * @lpfc_nvme_lport: Transport localport that LS is to be issued from.
   866	 * @lpfc_nvme_rport: Transport remoteport that LS is to be sent to.
   867	 * @pnvme_lsreq - the transport nvme_ls_req structure for the LS
   868	 *
   869	 * Driver registers this routine to abort a NVME LS request that is
   870	 * in progress (from the transports perspective).
   871	 **/
   872	static void
   873	lpfc_nvme_ls_abort(struct nvme_fc_local_port *pnvme_lport,
   874			   struct nvme_fc_remote_port *pnvme_rport,
   875			   struct nvmefc_ls_req *pnvme_lsreq)
   876	{
   877		struct lpfc_nvme_lport *lport;
   878		struct lpfc_vport *vport;
 > 879		struct lpfc_hba *phba;
   880		struct lpfc_nodelist *ndlp;
   881		int ret;
   882	
   883		lport = (struct lpfc_nvme_lport *)pnvme_lport->private;
   884		if (unlikely(!lport))
   885			return;
   886		vport = lport->vport;
   887		phba = vport->phba;
   888	
   889		if (vport->load_flag & FC_UNLOADING)
   890			return;
   891	
   892		ndlp = lpfc_findnode_did(vport, pnvme_rport->port_id);
   893	
   894		ret = __lpfc_nvme_ls_abort(vport, ndlp, pnvme_lsreq);
   895		if (!ret)
   896			atomic_inc(&lport->xmt_ls_abort);
   897	}
   898	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (51221 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ