linux-kernel - Re: [PATCH] erofs: derive atime instead of leaving it empty

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bf522e01-97c6-e9b7-6f28-f88b64233aaf@huawei.com>
Date:   Wed, 4 Nov 2020 08:57:07 +0800
From:   Chao Yu <yuchao0@...wei.com>
To:     Gao Xiang <hsiangkao@....com>, <linux-erofs@...ts.ozlabs.org>,
        Chao Yu <chao@...nel.org>
CC:     LKML <linux-kernel@...r.kernel.org>,
        Gao Xiang <hsiangkao@...hat.com>, nl6720 <nl6720@...il.com>,
        stable <stable@...r.kernel.org>
Subject: Re: [PATCH] erofs: derive atime instead of leaving it empty

On 2020/11/1 3:51, Gao Xiang wrote:
> From: Gao Xiang <hsiangkao@...hat.com>
> 
> EROFS has _only one_ ondisk timestamp (ctime is currently
> documented and recorded, we might also record mtime instead
> with a new compat feature if needed) for each extended inode
> since EROFS isn't mainly for archival purposes so no need to
> keep all timestamps on disk especially for Android scenarios
> due to security concerns. Also, romfs/cramfs don't have their
> own on-disk timestamp, and squashfs only records mtime instead.
> 
> Let's also derive access time from ondisk timestamp rather than
> leaving it empty, and if mtime/atime for each file are really
> needed for specific scenarios as well, we can also use xattrs
> to record them then.
> 
> Reported-by: nl6720 <nl6720@...il.com>
> [ Gao Xiang: It'd be better to backport for user-friendly concern. ]
> Fixes: 431339ba9042 ("staging: erofs: add inode operations")
> Cc: stable <stable@...r.kernel.org> # 4.19+
> Signed-off-by: Gao Xiang <hsiangkao@...hat.com>

Looks good to me. :)

Reviewed-by: Chao Yu <yuchao0@...wei.com>

Thanks,