linux-kernel - Re: [PATCH 5.9 374/391] null_blk: synchronization fix for zoned device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201104091045.GE1588160@kroah.com>
Date:   Wed, 4 Nov 2020 10:10:45 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Damien Le Moal <Damien.LeMoal@....com>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>,
        Kanchan Joshi <joshi.k@...sung.com>,
        Jens Axboe <axboe@...nel.dk>
Subject: Re: [PATCH 5.9 374/391] null_blk: synchronization fix for zoned
 device

On Tue, Nov 03, 2020 at 11:36:35PM +0000, Damien Le Moal wrote:
> On 2020/11/04 5:52, Greg Kroah-Hartman wrote:
> > From: Kanchan Joshi <joshi.k@...sung.com>
> > 
> > commit 35bc10b2eafbb701064b94f283b77c54d3304842 upstream.
> > 
> > Parallel write,read,zone-mgmt operations accessing/altering zone state
> > and write-pointer may get into race. Avoid the situation by using a new
> > spinlock for zoned device.
> > Concurrent zone-appends (on a zone) returning same write-pointer issue
> > is also avoided using this lock.
> > 
> > Cc: stable@...r.kernel.org
> > Fixes: e0489ed5daeb ("null_blk: Support REQ_OP_ZONE_APPEND")
> > Signed-off-by: Kanchan Joshi <joshi.k@...sung.com>
> > Reviewed-by: Damien Le Moal <damien.lemoal@....com>
> > Signed-off-by: Jens Axboe <axboe@...nel.dk>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> 
> Greg,
> 
> I sent a followup patch fixing a bug introduced by this patch, but I forgot to
> mark it for stable. The patch is
> 
> commit aa1c09cb65e2 "null_blk: Fix locking in zoned mode"
> 
> Could you pickup that one too please ?

It doesn't apply cleanly at all, can you provide a backport?

thanks,

greg k-h