[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <9ba500df-9d22-3a4e-056f-9bb5f2b42440@suse.com>
Date: Wed, 4 Nov 2020 10:31:43 +0100
From: Jürgen Groß <jgross@...e.com>
To: Lee Jones <lee.jones@...aro.org>, davem@...emloft.net,
kuba@...nel.org
Cc: linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
Boris Ostrovsky <boris.ostrovsky@...cle.com>,
Stefano Stabellini <sstabellini@...nel.org>,
Alexei Starovoitov <ast@...nel.org>,
Daniel Borkmann <daniel@...earbox.net>,
Jesper Dangaard Brouer <hawk@...nel.org>,
John Fastabend <john.fastabend@...il.com>,
Martin KaFai Lau <kafai@...com>,
Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
Andrii Nakryiko <andrii@...nel.org>,
KP Singh <kpsingh@...omium.org>,
xen-devel@...ts.xenproject.org, netdev@...r.kernel.org,
bpf@...r.kernel.org
Subject: Re: [PATCH 08/12] net: xen-netfront: Demote non-kernel-doc headers to
standard comment blocks
On 04.11.20 10:06, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/net/xen-netfront.c: In function ‘store_rxbuf’:
> drivers/net/xen-netfront.c:2416:16: warning: variable ‘target’ set but not used [-Wunused-but-set-variable]
Those two warnings are not fixed by the patch.
> drivers/net/xen-netfront.c:1592: warning: Function parameter or member 'dev' not described in 'netfront_probe'
> drivers/net/xen-netfront.c:1592: warning: Function parameter or member 'id' not described in 'netfront_probe'
> drivers/net/xen-netfront.c:1669: warning: Function parameter or member 'dev' not described in 'netfront_resume'
> drivers/net/xen-netfront.c:2313: warning: Function parameter or member 'dev' not described in 'netback_changed'
> drivers/net/xen-netfront.c:2313: warning: Function parameter or member 'backend_state' not described in 'netback_changed'
>
> Cc: Boris Ostrovsky <boris.ostrovsky@...cle.com>
> Cc: Juergen Gross <jgross@...e.com>
> Cc: Stefano Stabellini <sstabellini@...nel.org>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: Jakub Kicinski <kuba@...nel.org>
> Cc: Alexei Starovoitov <ast@...nel.org>
> Cc: Daniel Borkmann <daniel@...earbox.net>
> Cc: Jesper Dangaard Brouer <hawk@...nel.org>
> Cc: John Fastabend <john.fastabend@...il.com>
> Cc: Martin KaFai Lau <kafai@...com>
> Cc: Song Liu <songliubraving@...com>
> Cc: Yonghong Song <yhs@...com>
> Cc: Andrii Nakryiko <andrii@...nel.org>
> Cc: KP Singh <kpsingh@...omium.org>
> Cc: xen-devel@...ts.xenproject.org
> Cc: netdev@...r.kernel.org
> Cc: bpf@...r.kernel.org
> Signed-off-by: Lee Jones <lee.jones@...aro.org>
With the commit message fixed you can have my:
Reviewed-by: Juergen Gross <jgross@...e.com>
Juergen
Powered by blists - more mailing lists