linux-kernel - Re: [PATCH 4.19 056/191] powerpc: select ARCH_WANT_IRQS_OFF_ACTIVATE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87zh3xude6.fsf@mpe.ellerman.id.au>
Date:   Wed, 04 Nov 2020 12:19:45 +1100
From:   Michael Ellerman <mpe@...erman.id.au>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        stable@...r.kernel.org, Nicholas Piggin <npiggin@...il.com>,
        Sasha Levin <sashal@...nel.org>
Subject: Re: [PATCH 4.19 056/191] powerpc: select ARCH_WANT_IRQS_OFF_ACTIVATE_MM

Michael Ellerman <mpe@...erman.id.au> writes:
> Greg Kroah-Hartman <gregkh@...uxfoundation.org> writes:
>> From: Nicholas Piggin <npiggin@...il.com>
>>
>> [ Upstream commit 66acd46080bd9e5ad2be4b0eb1d498d5145d058e ]
>>
>> powerpc uses IPIs in some situations to switch a kernel thread away
>> from a lazy tlb mm, which is subject to the TLB flushing race
>> described in the changelog introducing ARCH_WANT_IRQS_OFF_ACTIVATE_MM.
>>
>> Signed-off-by: Nicholas Piggin <npiggin@...il.com>
>> Signed-off-by: Michael Ellerman <mpe@...erman.id.au>
>> Link: https://lore.kernel.org/r/20200914045219.3736466-3-npiggin@gmail.com
>> Signed-off-by: Sasha Levin <sashal@...nel.org>
>> ---
>>  arch/powerpc/Kconfig                   | 1 +
>>  arch/powerpc/include/asm/mmu_context.h | 2 +-
>>  2 files changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
>> index f38d153d25861..0bc53f0e37c0f 100644
>> --- a/arch/powerpc/Kconfig
>> +++ b/arch/powerpc/Kconfig
>> @@ -152,6 +152,7 @@ config PPC
>>  	select ARCH_USE_BUILTIN_BSWAP
>>  	select ARCH_USE_CMPXCHG_LOCKREF		if PPC64
>>  	select ARCH_WANT_IPC_PARSE_VERSION
>> +	select ARCH_WANT_IRQS_OFF_ACTIVATE_MM
>
> This depends on upstream commit:
>
>   d53c3dfb23c4 ("mm: fix exec activate_mm vs TLB shootdown and lazy tlb switching race")
>
>
> Which I don't see in 4.19 stable, or in the email thread here.
>
> So this shouldn't be backported to 4.19 unless that commit is also
> backported.

I just sent you a backport of d53c3dfb23c4 for 4.19.

cheers