linux-kernel - [PATCH v3 08/11] firmware: raspberrypi: Get rid of rpi_firmware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20201104103938.1286-9-nsaenzjulienne@suse.de>
Date:   Wed,  4 Nov 2020 11:39:34 +0100
From:   Nicolas Saenz Julienne <nsaenzjulienne@...e.de>
To:     u.kleine-koenig@...gutronix.de, linux-kernel@...r.kernel.org,
        Florian Fainelli <f.fainelli@...il.com>,
        Ray Jui <rjui@...adcom.com>,
        Scott Branden <sbranden@...adcom.com>,
        bcm-kernel-feedback-list@...adcom.com,
        Nicolas Saenz Julienne <nsaenzjulienne@...e.de>
Cc:     linux-pwm@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        devicetree@...r.kernel.org, wahrenst@....net,
        linux-input@...r.kernel.org, dmitry.torokhov@...il.com,
        gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
        p.zabel@...gutronix.de, linux-gpio@...r.kernel.org,
        linus.walleij@...aro.org, linux-clk@...r.kernel.org,
        sboyd@...nel.org, linux-rpi-kernel@...ts.infradead.org,
        bgolaszewski@...libre.com, andy.shevchenko@...il.com
Subject: [PATCH v3 08/11] firmware: raspberrypi: Get rid of rpi_firmware_get()

There a no users left to the function as they all converted to
devm_rpi_firmware_get(). Just get rid of it.

Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@...e.de>
---
 drivers/firmware/raspberrypi.c             | 17 -----------------
 include/soc/bcm2835/raspberrypi-firmware.h |  6 ------
 2 files changed, 23 deletions(-)

diff --git a/drivers/firmware/raspberrypi.c b/drivers/firmware/raspberrypi.c
index 74bdb3bde9dc..67f7105f3fd2 100644
--- a/drivers/firmware/raspberrypi.c
+++ b/drivers/firmware/raspberrypi.c
@@ -297,23 +297,6 @@ static void rpi_firmware_put(void *data)
 	wake_up(&fw->wait);
 }
 
-/**
- * rpi_firmware_get - Get pointer to rpi_firmware structure.
- * @firmware_node:    Pointer to the firmware Device Tree node.
- *
- * Returns NULL is the firmware device is not ready.
- */
-struct rpi_firmware *rpi_firmware_get(struct device_node *firmware_node)
-{
-	struct platform_device *pdev = of_find_device_by_node(firmware_node);
-
-	if (!pdev)
-		return NULL;
-
-	return platform_get_drvdata(pdev);
-}
-EXPORT_SYMBOL_GPL(rpi_firmware_get);
-
 /**
  * devm_rpi_firmware_get - Get pointer to rpi_firmware structure.
  * @firmware_node:    Pointer to the firmware Device Tree node.
diff --git a/include/soc/bcm2835/raspberrypi-firmware.h b/include/soc/bcm2835/raspberrypi-firmware.h
index 8fe64f53a394..eaa4e516e4c6 100644
--- a/include/soc/bcm2835/raspberrypi-firmware.h
+++ b/include/soc/bcm2835/raspberrypi-firmware.h
@@ -140,7 +140,6 @@ int rpi_firmware_property(struct rpi_firmware *fw,
 			  u32 tag, void *data, size_t len);
 int rpi_firmware_property_list(struct rpi_firmware *fw,
 			       void *data, size_t tag_size);
-struct rpi_firmware *rpi_firmware_get(struct device_node *firmware_node);
 struct rpi_firmware *devm_rpi_firmware_get(struct device *dev,
 					   struct device_node *firmware_node);
 #else
@@ -156,11 +155,6 @@ static inline int rpi_firmware_property_list(struct rpi_firmware *fw,
 	return -ENOSYS;
 }
 
-static inline struct rpi_firmware *rpi_firmware_get(struct device_node *firmware_node)
-{
-	return NULL;
-}
-
 static inline struct rpi_firmware *devm_rpi_firmware_get(struct device *dev,
 					struct device_node *firmware_node)
 {
-- 
2.29.1