linux-kernel - Re: [PATCH 6/8] clk: renesas: r8a779a0-cpg-mssr: add static to local function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdUQwk_oWBEv-ZweF0Z5MLATs4+1zdXdaf1ftit0rvav6Q@mail.gmail.com>
Date:   Wed, 4 Nov 2020 11:53:50 +0100
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Krzysztof Kozlowski <krzk@...nel.org>
Cc:     Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Sudeep Holla <sudeep.holla@....com>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        NXP Linux Team <linux-imx@....com>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Peng Fan <peng.fan@....com>, Abel Vesa <abel.vesa@....com>,
        Anson Huang <Anson.Huang@....com>,
        linux-clk <linux-clk@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        Linux-Renesas <linux-renesas-soc@...r.kernel.org>
Subject: Re: [PATCH 6/8] clk: renesas: r8a779a0-cpg-mssr: add static to local function

Hi Krzysztof,

On Tue, Nov 3, 2020 at 5:25 PM Krzysztof Kozlowski <krzk@...nel.org> wrote:
> The function rcar_r8a779a0_cpg_clk_register() is not used outside of the
> unit so it can be made static to fix compilation warning:
>
>     drivers/clk/renesas/r8a779a0-cpg-mssr.c:156:21: warning:
>         no previous prototype for ‘rcar_r8a779a0_cpg_clk_register’ [-Wmissing-prototypes]
>
> Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>

Thanks for your patch!
A fix for this is already queued in renesas-clk-for-v5.11:
https://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git/commit/?h=renesas-clk-for-v5.11&id=c3f207f6d23d01c0fa817fcd6118bbbc509abe39

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds