linux-kernel - Re: Re: [PATCH 0/2] drivers/tty: delete break after return or goto

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201104115903.GA1694605@kroah.com>
Date:   Wed, 4 Nov 2020 12:59:03 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Bernard <bernard@...o.com>
Cc:     Jiri Slaby <jirislaby@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        NXP Linux Team <linux-imx@....com>,
        linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, opensource.kernel@...o.com
Subject: Re: Re: [PATCH 0/2] drivers/tty: delete break after return or goto

On Wed, Nov 04, 2020 at 07:17:56PM +0800, Bernard wrote:
> 
> 
> From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Date: 2020-11-04 19:02:53
> To:  Bernard Zhao <bernard@...o.com>
> Cc:  Jiri Slaby <jirislaby@...nel.org>,Shawn Guo <shawnguo@...nel.org>,Sascha Hauer <s.hauer@...gutronix.de>,Pengutronix Kernel Team <kernel@...gutronix.de>,Fabio Estevam <festevam@...il.com>,NXP Linux Team <linux-imx@....com>,linux-kernel@...r.kernel.org,linux-serial@...r.kernel.org,linux-arm-kernel@...ts.infradead.org,opensource.kernel@...o.com
> Subject: Re: [PATCH 0/2] drivers/tty: delete break after return or goto>On Wed, Nov 04, 2020 at 02:53:29AM -0800, Bernard Zhao wrote:
> >> This patch sereies optimise code like:
> >> {
> >> case XXX:
> >> 	return XXX;
> >> 	break; //The break is meanless, so just delete it.
> >> case YYY:
> >> 	goto YYY;
> >> 	break; //The break is meanless, so just delete it.
> >> ......
> >> }
> >> 
> >> Signed-off-by: Bernard Zhao <bernard@...o.com>
> >> 
> >> ---
> >> Bernard Zhao (2):
> >>   drivers/tty/nozomi.c: delete no use break after goto
> >>   drivers/tty/serial/imx.c: delete no use break after return
> >
> >That is not the subject of the patches you sent out, what broke?
> 
> Hi:
> 
> I am sorry that I am a little confused:
> The patch series`s subject is "drivers/tty: delete break after return or goto"
> and the blurb is:
> This patch sereies optimise code like:
> {
> case XXX:
> 	return XXX;
> 	break; //The break is meanless, so just delete it.
> case YYY:
> 	goto YYY;
> 	break; //The break is meanless, so just delete it.
> ......
> }
> last, the modified files are:
> Bernard Zhao (2):
>   drivers/tty/nozomi.c: delete no use break after goto
>   drivers/tty/serial/imx.c: delete no use break after return
> 
> Is there something wrong that I didn`t catch?

The above lines do not match up with the subject lines of the patches
you sent out, so something went wrong.

thanks,

greg k-h