linux-kernel - Re: [PATCH 1/4] erofs: fix setting up pcluster for temporary pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e4cbe373-ca69-5f95-99c7-422375c58e4e@huawei.com>
Date:   Wed, 4 Nov 2020 09:44:56 +0800
From:   Chao Yu <yuchao0@...wei.com>
To:     Gao Xiang <hsiangkao@...hat.com>
CC:     Gao Xiang <hsiangkao@....com>, <linux-erofs@...ts.ozlabs.org>,
        Chao Yu <chao@...nel.org>, LKML <linux-kernel@...r.kernel.org>,
        <stable@...r.kernel.org>
Subject: Re: [PATCH 1/4] erofs: fix setting up pcluster for temporary pages

On 2020/11/4 9:11, Gao Xiang wrote:
> On Wed, Nov 04, 2020 at 09:05:56AM +0800, Chao Yu wrote:
>> On 2020/10/22 22:57, Gao Xiang wrote:
>>> From: Gao Xiang <hsiangkao@...hat.com>
>>>
>>> pcluster should be only set up for all managed pages instead of
>>> temporary pages. Since it currently uses page->mapping to identify,
>>> the impact is minor for now.
>>>
>>> Fixes: 5ddcee1f3a1c ("erofs: get rid of __stagingpage_alloc helper")
>>> Cc: <stable@...r.kernel.org> # 5.5+
>>> Signed-off-by: Gao Xiang <hsiangkao@...hat.com>
>>
>> Reviewed-by: Chao Yu <yuchao0@...wei.com>
> 
> Thanks, I've also added a note to the commit message like this,
> "
> [ Update: Vladimir reported the kernel log becomes polluted
>    because PAGE_FLAGS_CHECK_AT_FREE flag(s) set if the page
>    allocation debug option is enabled. ]
> "
> Will apply all of this to -fixes branch.

Thanks for noticing that, looks fine to me.

Thanks,

> 
> Thanks,
> Gao Xiang
> 
>>
>> Thanks,
>>
> 
> .
>