linux-kernel - Re: [PATCH v8 2/7] interconnect: Add generic interconnect driver for Exynos SoCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <346da718-2340-c862-9a1a-c5f64aae19c2@samsung.com>
Date:   Wed, 4 Nov 2020 14:22:37 +0100
From:   Sylwester Nawrocki <s.nawrocki@...sung.com>
To:     Krzysztof Kozlowski <krzk@...nel.org>
Cc:     georgi.djakov@...aro.org, cw00.choi@...sung.com,
        devicetree@...r.kernel.org, robh+dt@...nel.org,
        a.swigon@...sung.com, myungjoo.ham@...sung.com,
        inki.dae@...sung.com, sw0312.kim@...sung.com,
        b.zolnierkie@...sung.com, m.szyprowski@...sung.com,
        linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
        linux-samsung-soc@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v8 2/7] interconnect: Add generic interconnect driver
 for Exynos SoCs

On 04.11.2020 13:37, Krzysztof Kozlowski wrote:
> On Wed, Nov 04, 2020 at 11:36:52AM +0100, Sylwester Nawrocki wrote:

>> diff --git a/drivers/interconnect/Makefile b/drivers/interconnect/Makefile
>> index d203520..c2f9e9d 100644
>> --- a/drivers/interconnect/Makefile
>> +++ b/drivers/interconnect/Makefile
>> @@ -6,3 +6,4 @@ icc-core-objs				:= core.o bulk.o
>>  obj-$(CONFIG_INTERCONNECT)		+= icc-core.o
>>  obj-$(CONFIG_INTERCONNECT_IMX)		+= imx/
>>  obj-$(CONFIG_INTERCONNECT_QCOM)		+= qcom/
>> +obj-$(CONFIG_INTERCONNECT_SAMSUNG)	+= samsung/
>> \ No newline at end of file
> 
> This needs a fix.

Corrected, thanks for pointing out.
 
>> diff --git a/drivers/interconnect/samsung/Kconfig b/drivers/interconnect/samsung/Kconfig
>> new file mode 100644
>> index 0000000..508ed64
>> --- /dev/null
>> +++ b/drivers/interconnect/samsung/Kconfig
>> @@ -0,0 +1,13 @@
>> +# SPDX-License-Identifier: GPL-2.0-only
>> +config INTERCONNECT_SAMSUNG
>> +	bool "Samsung interconnect drivers"
> 
> "Samsung SoC interconnect drivers"

Changed.

>> +	depends on ARCH_EXYNOS || COMPILE_TEST
> 
> Don't the depend on INTERCONNECT?

This file gets included only if INTERCONNECT is enabled, see
higher level Kconfig file.
 
>> +	help
>> +	  Interconnect drivers for Samsung SoCs.
>> +
>> +
> 
> One line break

Fixed.

>> +config INTERCONNECT_EXYNOS
>> +	tristate "Exynos generic interconnect driver"
>> +	depends on INTERCONNECT_SAMSUNG
> 
> How about:
> default y if ARCH_EXYNOS

OK, added.

>> +	help
>> +	  Generic interconnect driver for Exynos SoCs.
>> diff --git a/drivers/interconnect/samsung/Makefile b/drivers/interconnect/samsung/Makefile
>> new file mode 100644
>> index 0000000..e19d1df
>> --- /dev/null
>> +++ b/drivers/interconnect/samsung/Makefile
>> @@ -0,0 +1,4 @@
>> +# SPDX-License-Identifier: GPL-2.0
>> +exynos-interconnect-objs		:= exynos.o
> 
> What is this line for?
 
That allows to change the module name, so it's exynos-interconnect.ko
rather than just exynos.c. It's done similarly for other SoCs in 
the subsystem.

>> +obj-$(CONFIG_INTERCONNECT_EXYNOS)	+= exynos-interconnect.o

-- 
Regards,
Sylwester