linux-kernel - Re: [PATCH bpf-next v2 5/8] bpf: Fix tests for local

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 4 Nov 2020 00:16:09 +0000
From:   Song Liu <songliubraving@...com>
To:     KP Singh <kpsingh@...omium.org>
CC:     open list <linux-kernel@...r.kernel.org>,
        bpf <bpf@...r.kernel.org>, Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Martin Lau <kafai@...com>, Paul Turner <pjt@...gle.com>,
        Jann Horn <jannh@...gle.com>, Hao Luo <haoluo@...gle.com>
Subject: Re: [PATCH bpf-next v2 5/8] bpf: Fix tests for local_storage



> On Nov 3, 2020, at 7:31 AM, KP Singh <kpsingh@...omium.org> wrote:
> 
> From: KP Singh <kpsingh@...gle.com>
> 
> The {inode,sk}_storage_result checking if the correct value was retrieved
> was being clobbered unconditionally by the return value of the
> bpf_{inode,sk}_storage_delete call.
> 
> Also, consistently use the newly added BPF_LOCAL_STORAGE_GET_F_CREATE
> flag.
> 
> Fixes: cd324d7abb3d ("bpf: Add selftests for local_storage")
> Signed-off-by: KP Singh <kpsingh@...gle.com>

Acked-by: Song Liu <songliubraving@...com>

[...]