linux-kernel - Re: [PATCH 1/3] gpio: pcie-idio-24: Fix irq mask when masking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201104154708.GB406355@shinobu>
Date:   Wed, 4 Nov 2020 10:47:08 -0500
From:   William Breathitt Gray <vilhelm.gray@...il.com>
To:     Arnaud de Turckheim <quarium@...il.com>
Cc:     linus.walleij@...aro.org, bgolaszewski@...libre.com,
        linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org
Subject: Re: [PATCH 1/3] gpio: pcie-idio-24: Fix irq mask when masking

On Wed, Nov 04, 2020 at 04:24:53PM +0100, Arnaud de Turckheim wrote:
> Fix the bitwise operation to remove only the corresponding bit from the
> mask.
> 
> Fixes: 585562046628 ("gpio: Add GPIO support for the ACCES PCIe-IDIO-24 family")
> Signed-off-by: Arnaud de Turckheim <quarium@...il.com>

Reviewed-by: William Breathitt Gray <vilhelm.gray@...il.com>

> ---
>  drivers/gpio/gpio-pcie-idio-24.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpio/gpio-pcie-idio-24.c b/drivers/gpio/gpio-pcie-idio-24.c
> index a68941d19ac6..5ea517416366 100644
> --- a/drivers/gpio/gpio-pcie-idio-24.c
> +++ b/drivers/gpio/gpio-pcie-idio-24.c
> @@ -339,7 +339,7 @@ static void idio_24_irq_mask(struct irq_data *data)
>  
>  	raw_spin_lock_irqsave(&idio24gpio->lock, flags);
>  
> -	idio24gpio->irq_mask &= BIT(bit_offset);
> +	idio24gpio->irq_mask &= ~BIT(bit_offset);
>  	new_irq_mask = idio24gpio->irq_mask >> bank_offset;
>  
>  	if (!new_irq_mask) {
> -- 
> 2.25.1
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)