linux-kernel - Re: [PATCH] ACPI: Remove trailing whitespace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6d888eb0-bfc5-28ff-c62f-9e769f77bc1f@gmail.com>
Date:   Wed, 4 Nov 2020 16:48:09 +0100
From:   Maximilian Luz <luzmaximilian@...il.com>
To:     Joe Perches <joe@...ches.com>, Bjorn Helgaas <helgaas@...nel.org>
Cc:     linux-acpi@...r.kernel.org,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Len Brown <lenb@...nel.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>, linux-pci@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ACPI: Remove trailing whitespace

On 11/4/20 6:13 AM, Joe Perches wrote:

[...]

>> Yes. I scanned drivers/acpi for trailing whitespaces after I noticed a
>> couple of them. I did not explicitly scan for other stuff like spaces
>> where there should be tabs, mostly because I haven't found a quick and
>> reliable solution for that. I only noticed an inconsistent indentation
>> when committing, so I fixed that too.
> 
> You could try:
> 
> $ git ls-files -- 'drivers/acpi/*.[ch]' | \
>    xargs ./scripts/checkpatch.pl -f --fix-inplace --types=CODE_INDENT

Thanks, that indeed looks like a decent solution.

> Right now that produces:
> ---

[...]

> diff --git a/drivers/acpi/ac.c b/drivers/acpi/ac.c
> index 46a64e9fa716..46be80976a03 100644
> --- a/drivers/acpi/ac.c
> +++ b/drivers/acpi/ac.c
> @@ -89,7 +89,7 @@ struct acpi_ac {
>   #define to_acpi_ac(x) power_supply_get_drvdata(x)
>   
>   /* --------------------------------------------------------------------------
> -                               AC Adapter Management
> +			       AC Adapter Management
>      -------------------------------------------------------------------------- */

I'm not too sure about the comments, but I can find the time to look
over the output and adjust that if that's something you'd want me to do.

Regards,
Max