linux-kernel - Re: [PATCH 07/20] input: keyboard: cros_ec_keyb: Struct headers should start with 'struct <name>'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201104171536.GB2322691@google.com>
Date:   Wed, 4 Nov 2020 09:15:36 -0800
From:   Benson Leung <bleung@...gle.com>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     linux-kernel@...r.kernel.org,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Benson Leung <bleung@...omium.org>,
        Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        Guenter Roeck <groeck@...omium.org>,
        linux-input@...r.kernel.org
Subject: Re: [PATCH 07/20] input: keyboard: cros_ec_keyb: Struct headers
 should start with 'struct <name>'

Hi Lee,

On Wed, Nov 04, 2020 at 04:24:14PM +0000, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
> 
>  drivers/input/keyboard/cros_ec_keyb.c:72: warning: cannot understand function prototype: 'struct cros_ec_bs_map '
> 
> Cc: Dmitry Torokhov <dmitry.torokhov@...il.com>
> Cc: Benson Leung <bleung@...omium.org>
> Cc: Enric Balletbo i Serra <enric.balletbo@...labora.com>
> Cc: Guenter Roeck <groeck@...omium.org>
> Cc: linux-input@...r.kernel.org
> Signed-off-by: Lee Jones <lee.jones@...aro.org>

Reviewed-by: Benson Leung <bleung@...omium.org>

> ---
>  drivers/input/keyboard/cros_ec_keyb.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/input/keyboard/cros_ec_keyb.c b/drivers/input/keyboard/cros_ec_keyb.c
> index 15d17c7170816..fce0c839e1430 100644
> --- a/drivers/input/keyboard/cros_ec_keyb.c
> +++ b/drivers/input/keyboard/cros_ec_keyb.c
> @@ -58,10 +58,9 @@ struct cros_ec_keyb {
>  	struct notifier_block notifier;
>  };
>  
> -
>  /**
> - * cros_ec_bs_map - Struct mapping Linux keycodes to EC button/switch bitmap
> - * #defines
> + * struct cros_ec_bs_map - Struct mapping Linux keycodes to EC button/switch
> + *			   bitmap #defines
>   *
>   * @ev_type: The type of the input event to generate (e.g., EV_KEY).
>   * @code: A linux keycode
> -- 
> 2.25.1
> 

-- 
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
bleung@...gle.com
Chromium OS Project
bleung@...omium.org

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)