linux-kernel - Re: [PATCH] mm/gup_benchmark: mark gup_benchmark_init as _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201105195235.GI36674@ziepe.ca>
Date:   Thu, 5 Nov 2020 15:52:35 -0400
From:   Jason Gunthorpe <jgg@...pe.ca>
To:     Barry Song <song.bao.hua@...ilicon.com>
Cc:     akpm@...ux-foundation.org, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, linuxarm@...wei.com,
        John Hubbard <jhubbard@...dia.com>, Jan Kara <jack@...e.cz>,
        Jérôme Glisse <jglisse@...hat.com>,
        "Matthew Wilcox (Oracle)" <willy@...radead.org>,
        Al Viro <viro@...iv.linux.org.uk>,
        Christoph Hellwig <hch@...radead.org>,
        Dan Williams <dan.j.williams@...el.com>,
        Dave Chinner <david@...morbit.com>,
        Jonathan Corbet <corbet@....net>,
        Michal Hocko <mhocko@...e.com>,
        Mike Kravetz <mike.kravetz@...cle.com>,
        Shuah Khan <shuah@...nel.org>, Vlastimil Babka <vbabka@...e.cz>
Subject: Re: [PATCH] mm/gup_benchmark: mark gup_benchmark_init as __init
 function

On Tue, Nov 03, 2020 at 09:10:16PM +1300, Barry Song wrote:
> gup_benchmark_init() is only called during initialization, mark it as
> __init to save some memory.
> 
> Cc: John Hubbard <jhubbard@...dia.com>
> Cc: Jan Kara <jack@...e.cz>
> Cc: Jérôme Glisse <jglisse@...hat.com>
> Cc: "Matthew Wilcox (Oracle)" <willy@...radead.org>
> Cc: Al Viro <viro@...iv.linux.org.uk>
> Cc: Christoph Hellwig <hch@...radead.org>
> Cc: Dan Williams <dan.j.williams@...el.com>
> Cc: Dave Chinner <david@...morbit.com>
> Cc: Jason Gunthorpe <jgg@...pe.ca>
> Cc: Jonathan Corbet <corbet@....net>
> Cc: Michal Hocko <mhocko@...e.com>
> Cc: Mike Kravetz <mike.kravetz@...cle.com>
> Cc: Shuah Khan <shuah@...nel.org>
> Cc: Vlastimil Babka <vbabka@...e.cz>
> Signed-off-by: Barry Song <song.bao.hua@...ilicon.com>
> ---
>  mm/gup_benchmark.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Hardly seems worthwhile, but looks correct

Reviewed-by: Jason Gunthorpe <jgg@...dia.com>

Jason