linux-kernel - Re: [PATCH v3 1/3] dt-bindings: Convert graph bindings to json-schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 5 Nov 2020 22:43:49 +0100
From:   Sam Ravnborg <sam@...nborg.org>
To:     Rob Herring <robh@...nel.org>
Cc:     devicetree@...r.kernel.org, Sameer Pujar <spujar@...dia.com>,
        Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>,
        kuninori.morimoto.gx@...esas.com, linux-kernel@...r.kernel.org,
        dri-devel@...ts.freedesktop.org,
        Thierry Reding <thierry.reding@...il.com>,
        Jacopo Mondi <jacopo+renesas@...ndi.org>
Subject: Re: [PATCH v3 1/3] dt-bindings: Convert graph bindings to json-schema

Hi Rob/Sameer


On Mon, Nov 02, 2020 at 02:36:54PM -0600, Rob Herring wrote:
> From: Sameer Pujar <spujar@...dia.com>
> 
> Convert device tree bindings of graph to YAML format. Currently graph.txt
> doc is referenced in multiple files and all of these need to use schema
> references. For now graph.txt is updated to refer to graph.yaml.
> 
> For users of the graph binding, they should reference to the graph
> schema from either 'ports' or 'port' property:
> 
> properties:
>   ports:
>     type: object
>     $ref: graph.yaml#/properties/ports
Please fix so this example is correct - append /schemas/

> 
>     properties:
>       port@0:
>         description: What data this port has
> 
>       ...
> 
> Or:
> 
> properties:
>   port:
>     description: What data this port has
>     type: object
>     $ref: graph.yaml#/properties/port
Likewise.

Otherwise I could be confused when looking it up later.

> 
> Signed-off-by: Sameer Pujar <spujar@...dia.com>
> Acked-by: Philipp Zabel <p.zabel@...gutronix.de>
> Signed-off-by: Rob Herring <robh@...nel.org>

With the changelog fixed:
Reviewed-by: Sam Ravnborg <sam@...nborg.org>