linux-kernel - Re: [PATCH v2 1/3] drm: panel: simple: Allow timing constraints, not fixed delays

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAD=FV=U7PvC5nL3EudxE62MSHeha+zd1u_hCxYyCw8t5SaWUkQ@mail.gmail.com>
Date:   Thu, 5 Nov 2020 13:54:31 -0800
From:   Doug Anderson <dianders@...omium.org>
To:     Thierry Reding <thierry.reding@...il.com>,
        Sam Ravnborg <sam@...nborg.org>
Cc:     Daniel Vetter <daniel@...ll.ch>, Rob Herring <robh+dt@...nel.org>,
        Rob Clark <robdclark@...omium.org>,
        dri-devel <dri-devel@...ts.freedesktop.org>,
        David Airlie <airlied@...ux.ie>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 1/3] drm: panel: simple: Allow timing constraints, not
 fixed delays

Hi,

On Wed, Oct 28, 2020 at 3:58 PM Douglas Anderson <dianders@...omium.org> wrote:
> @@ -249,18 +327,19 @@ static int panel_simple_unprepare(struct drm_panel *panel)
>  {
>         struct panel_simple *p = to_panel_simple(panel);
>
> -       if (!p->prepared)
> +       if (p->prepared_time != 0)

Though I swear I tested this, clearly I didn't test well enough.  I
was poking with this patch series some more and realized that I got
the above (and the one in _prepare) totally and utterly backwards.
I'll send out a v3 now...

-Doug