linux-kernel - [PATCH] rtc: hym8563: enable wakeup by default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <4a52fe66b327fd1974f86b7deb7e2c06d74fe64f.1604613067.git.guillaume.tucker@collabora.com>
Date:   Thu,  5 Nov 2020 22:01:10 +0000
From:   Guillaume Tucker <guillaume.tucker@...labora.com>
To:     Alessandro Zummo <a.zummo@...ertech.it>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Heiko Stuebner <heiko@...ech.de>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        linux-rtc@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel@...labora.com,
        Guillaume Tucker <guillaume.tucker@...labora.com>
Subject: [PATCH] rtc: hym8563: enable wakeup by default

Enable wakeup by default in the hym8563 driver to match the behaviour
implemented by the majority of RTC drivers.  As per the description of
device_init_wakeup(), it should be enabled for "devices that everyone
expects to be wakeup sources".  One would expect this to be the case
with a real-time clock.

Fixes: dcaf03849352 ("rtc: add hym8563 rtc-driver")
Reported-by: kernelci.org bot <bot@...nelci.org>
Signed-off-by: Guillaume Tucker <guillaume.tucker@...labora.com>
---
 drivers/rtc/rtc-hym8563.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/rtc/rtc-hym8563.c b/drivers/rtc/rtc-hym8563.c
index 0fb79c4afb46..6fccfe634d57 100644
--- a/drivers/rtc/rtc-hym8563.c
+++ b/drivers/rtc/rtc-hym8563.c
@@ -527,7 +527,7 @@ static int hym8563_probe(struct i2c_client *client,
 	hym8563->client = client;
 	i2c_set_clientdata(client, hym8563);
 
-	device_set_wakeup_capable(&client->dev, true);
+	device_init_wakeup(&client->dev, true);
 
 	ret = hym8563_init_device(client);
 	if (ret) {
-- 
2.20.1