linux-kernel - Re: [PATCH 1/4] clk: sifive: Extract prci core to common base

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <160454434294.3965362.6100009498384462585@swboyd.mtv.corp.google.com>
Date:   Wed, 04 Nov 2020 18:45:42 -0800
From:   Stephen Boyd <sboyd@...nel.org>
To:     Zong Li <zong.li@...ive.com>, aou@...s.berkeley.edu,
        linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-riscv@...ts.infradead.org, mturquette@...libre.com,
        palmer@...belt.com, paul.walmsley@...ive.com, yash.shah@...ive.com
Cc:     Zong Li <zong.li@...ive.com>
Subject: Re: [PATCH 1/4] clk: sifive: Extract prci core to common base

Quoting Zong Li (2020-10-16 02:18:23)
> Extract common core of prci driver to an independent file, it could
> allow other chips to reuse it. Separate SoCs-dependent code 'fu540'
> from prci core, then we can easily add 'fu740' later.

Please indicate if there are any functional changes or this is just code
movement.

> 
> Signed-off-by: Zong Li <zong.li@...ive.com>
> ---
>  drivers/clk/sifive/Makefile      |   2 +
>  drivers/clk/sifive/fu540-prci.c  | 586 +------------------------------
>  drivers/clk/sifive/fu540-prci.h  |  21 ++
>  drivers/clk/sifive/sifive-prci.c | 409 +++++++++++++++++++++
>  drivers/clk/sifive/sifive-prci.h | 201 +++++++++++

How much of this is a copy/pastes? Can you generate patches with
format-patch -M -C to try to find copies and renames?

>  5 files changed, 652 insertions(+), 567 deletions(-)
>  create mode 100644 drivers/clk/sifive/fu540-prci.h
>  create mode 100644 drivers/clk/sifive/sifive-prci.c
>  create mode 100644 drivers/clk/sifive/sifive-prci.h
>