linux-kernel - Re: [PATCH net-next v2 07/19] net: phy: mscc: implement generic .handle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201105000856.ff46ng36ioqwcnlf@skbuf>
Date:   Thu, 5 Nov 2020 02:08:56 +0200
From:   Vladimir Oltean <olteanv@...il.com>
To:     Ioana Ciornei <ciorneiioana@...il.com>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Russell King <linux@...linux.org.uk>,
        Florian Fainelli <f.fainelli@...il.com>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, Ioana Ciornei <ioana.ciornei@....com>
Subject: Re: [PATCH net-next v2 07/19] net: phy: mscc: implement generic
 .handle_interrupt() callback

On Sun, Nov 01, 2020 at 02:51:02PM +0200, Ioana Ciornei wrote:
> From: Ioana Ciornei <ioana.ciornei@....com>
> 
> In an attempt to actually support shared IRQs in phylib, we now move the
> responsibility of triggering the phylib state machine or just returning
> IRQ_NONE, based on the IRQ status register, to the PHY driver. Having
> 3 different IRQ handling callbacks (.handle_interrupt(),
> .did_interrupt() and .ack_interrupt() ) is confusing so let the PHY
> driver implement directly an IRQ handler like any other device driver.
> Make this driver follow the new convention.
> 
> Also, remove the .did_interrupt() callback since it's not anymore used.
> 
> Signed-off-by: Ioana Ciornei <ioana.ciornei@....com>
> ---

Tested-by: Vladimir Oltean <olteanv@...il.com> # VSC8514