lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 5 Nov 2020 16:55:41 +0800 From: Alex Shi <alex.shi@...ux.alibaba.com> To: akpm@...ux-foundation.org, mgorman@...hsingularity.net, tj@...nel.org, hughd@...gle.com, khlebnikov@...dex-team.ru, daniel.m.jordan@...cle.com, willy@...radead.org, hannes@...xchg.org, lkp@...el.com, linux-mm@...ck.org, linux-kernel@...r.kernel.org, cgroups@...r.kernel.org, shakeelb@...gle.com, iamjoonsoo.kim@....com, richard.weiyang@...il.com, kirill@...temov.name, alexander.duyck@...il.com, rong.a.chen@...el.com, mhocko@...e.com, vdavydov.dev@...il.com, shy828301@...il.com Cc: Alexander Duyck <alexander.h.duyck@...ux.intel.com>, Michal Hocko <mhocko@...nel.org> Subject: [PATCH v21 11/19] mm/vmscan: remove lruvec reget in move_pages_to_lru Isolated page shouldn't be recharged by memcg since the memcg migration isn't possible at the time. All pages were isolated from the same lruvec (and isolation inhibits memcg migration). So remove unnecessary regetting. Thanks to Alexander Duyck for pointing this out. Signed-off-by: Alex Shi <alex.shi@...ux.alibaba.com> Acked-by: Hugh Dickins <hughd@...gle.com> Acked-by: Johannes Weiner <hannes@...xchg.org> Cc: Alexander Duyck <alexander.h.duyck@...ux.intel.com> Cc: Andrew Morton <akpm@...ux-foundation.org> Cc: Konstantin Khlebnikov <khlebnikov@...dex-team.ru> Cc: Michal Hocko <mhocko@...nel.org> Cc: Hugh Dickins <hughd@...gle.com> Cc: Johannes Weiner <hannes@...xchg.org> Cc: linux-mm@...ck.org Cc: linux-kernel@...r.kernel.org Cc: cgroups@...r.kernel.org --- mm/vmscan.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/mm/vmscan.c b/mm/vmscan.c index d771f812e983..cb2f6256a7d6 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -1887,7 +1887,12 @@ static unsigned noinline_for_stack move_pages_to_lru(struct lruvec *lruvec, continue; } - lruvec = mem_cgroup_page_lruvec(page, pgdat); + /* + * All pages were isolated from the same lruvec (and isolation + * inhibits memcg migration). + */ + VM_BUG_ON_PAGE(mem_cgroup_page_lruvec(page, page_pgdat(page)) + != lruvec, page); lru = page_lru(page); nr_pages = thp_nr_pages(page); -- 1.8.3.1
Powered by blists - more mailing lists