linux-kernel - Re: [PATCH 35/36] tty: synclink: Mark disposable variables as __always

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 5 Nov 2020 09:00:39 +0000
From:   Lee Jones <lee.jones@...aro.org>
To:     Jiri Slaby <jirislaby@...nel.org>
Cc:     linux-kernel@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        paulkf@...rogate.com
Subject: Re: [PATCH 35/36] tty: synclink: Mark disposable variables as
 __always_unused

On Thu, 05 Nov 2020, Jiri Slaby wrote:

> On 04. 11. 20, 20:35, Lee Jones wrote:
> > Fixes the following W=1 kernel build warning(s):
> > 
> >   drivers/tty/synclink.c: In function ‘usc_reset’:
> >   drivers/tty/synclink.c:5571:6: warning: variable ‘readval’ set but not used [-Wunused-but-set-variable]
> >   drivers/tty/synclink.c: In function ‘mgsl_load_pci_memory’:
> >   drivers/tty/synclink.c:7267:16: warning: variable ‘Dummy’ set but not used [-Wunused-but-set-variable]
> > 
> > Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> > Cc: Jiri Slaby <jirislaby@...nel.org>
> > Cc: paulkf@...rogate.com
> > Signed-off-by: Lee Jones <lee.jones@...aro.org>
> > ---
> >   drivers/tty/synclink.c | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/tty/synclink.c b/drivers/tty/synclink.c
> > index c8324d58ef564..8ed64b1e7c378 100644
> > --- a/drivers/tty/synclink.c
> > +++ b/drivers/tty/synclink.c
> > @@ -5568,7 +5568,7 @@ static void usc_load_txfifo( struct mgsl_struct *info )
> >   static void usc_reset( struct mgsl_struct *info )
> >   {
> >   	int i;
> > -	u32 readval;
> > +	u32 __always_unused readval;
> 
> The same as in synclinkmp.
> 
> >   	/* Set BIT30 of Misc Control Register */
> >   	/* (Local Control Register 0x50) to force reset of USC. */
> > @@ -7264,7 +7264,7 @@ static void mgsl_load_pci_memory( char* TargetPtr, const char* SourcePtr,
> >   	unsigned short Intervalcount = count / PCI_LOAD_INTERVAL;
> >   	unsigned short Index;
> > -	unsigned long Dummy;
> > +	unsigned long __always_unused Dummy;
> 
> You can kill it completely.

Great.  Will fix.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog