linux-kernel - Re: [PATCH v1 1/2] dt-bindings: leds: Add bindings for intel LGM SOC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201105095257.GA7994@amd>
Date:   Thu, 5 Nov 2020 10:52:57 +0100
From:   Pavel Machek <pavel@....cz>
To:     Amireddy Mallikarjuna reddy <mallikarjunax.reddy@...ux.intel.com>
Cc:     linux-leds@...r.kernel.org, dmurphy@...com,
        devicetree@...r.kernel.org, robh+dt@...nel.org,
        linux-kernel@...r.kernel.org, cheol.yong.kim@...el.com,
        qi-ming.wu@...el.com, malliamireddy009@...il.com,
        yixin.zhu@...el.com
Subject: Re: [PATCH v1 1/2] dt-bindings: leds: Add bindings for intel LGM SOC

On Thu 2020-11-05 17:43:50, Amireddy Mallikarjuna reddy wrote:
> Add DT bindings YAML schema for SSO controller driver
> of Lightning Mountain(LGM) SoC.
>

intel -> Intel in the title.
"Lightning Mountain(LGM)" -> 'Lightning Mountain (LGM)"

> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/leds/leds-lgm.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Intel LGM Soc LED SSO driver

Please spell out LGM and SSO here. Soc -> SoC?


> +          intel,sso-brightness:
> +            $ref: /schemas/types.yaml#/definitions/uint32
> +            description: brightness level of the LED.
> +            minimum: 0
> +            maximum: 255

?

> +          intel,sso-hw-trigger:
> +            type: boolean
> +            description: This property indicates Hardware driven/control LED.

Why is this intel specific?

> +          intel,sso-hw-blink:
> +            type: boolean
> +            description: This property indicates Enable LED blink by Hardware.

?

> +          intel,sso-blink-rate:
> +            $ref: /schemas/types.yaml#/definitions/uint32
> +            description: LED HW blink frequency.

?

Best regards,
						Pavel
-- 
http://www.livejournal.com/~pavelmachek

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)