linux-kernel - Re: [PATCH 27/36] tty: synclinkmp: Mark never checked 'readval' as __always

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201105100520.GI4488@dell>
Date:   Thu, 5 Nov 2020 10:05:20 +0000
From:   Lee Jones <lee.jones@...aro.org>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Paul Fulghum <paulkf@...rogate.com>,
        Jiri Slaby <jirislaby@...nel.org>,
        "linux-kernel@...r.kernel.org Mailing List" 
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 27/36] tty: synclinkmp: Mark never checked 'readval' as
 __always_unused

On Thu, 05 Nov 2020, Greg Kroah-Hartman wrote:

> On Thu, Nov 05, 2020 at 01:39:36AM -0800, Paul Fulghum wrote:
> > 
> > 
> > > On Nov 5, 2020, at 1:10 AM, Jiri Slaby <jirislaby@...nel.org> wrote:
> > > 
> > > OK, let the loop alone. I would bet a half a pig that noone is able to test this driver. But one has to write this for someone to raise and admit they are still using it. In fact, there are _4_ google replies to "Microgate Corporation" "SyncLink Multiport Adapter" "lspci".
> > 
> > 
> > 
> > The hardware used with synclink.c and synclinkmp.c has not been
> manufactured for 15 years and was low volume. The chances of either
> driver still being in use is very low. Not even Microgate (me) has
> the ability to test either anymore (no hardware). I don’t know the
> policy about driver removal, but I think both could be removed
> without upsetting anyone.
> > 
> > synclink_gt.c is still in production and the driver still actively used.
> > 
> > If there are no objections to removing the the old drivers
> > (synclink.c/synclink_mp.c) I could make a patch to do so tomorrow
> > (it is 1:30am here now). Nothing eliminates niggling warnings like
> > removing dead code. 
> 
> Great, please submit a patch to remove these, I will always take patches
> to delete lines :)

Good resolution.  I'm happy to do this.  Bear with me.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog