linux-kernel - Re: [PATCH] mmc: moxart: replace spin_lock_irqsave by spin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPDyKFrsyUHAuHKZ3JbprK5aCOogRcYzaUJ2z4Wg1+AthDUrHg@mail.gmail.com>
Date:   Thu, 5 Nov 2020 13:58:51 +0100
From:   Ulf Hansson <ulf.hansson@...aro.org>
To:     Tian Tao <tiantao6@...ilicon.com>
Cc:     "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mmc: moxart: replace spin_lock_irqsave by spin_lock in
 hard IRQ

On Fri, 30 Oct 2020 at 02:28, Tian Tao <tiantao6@...ilicon.com> wrote:
>
> The code has been in a irq-disabled context since it is hard IRQ. There
> is no necessity to do it again.
>
> Signed-off-by: Tian Tao <tiantao6@...ilicon.com>

Applied for next, thanks!

Kind regards
Uffe


> ---
>  drivers/mmc/host/moxart-mmc.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mmc/host/moxart-mmc.c b/drivers/mmc/host/moxart-mmc.c
> index f25079b..89bff4e 100644
> --- a/drivers/mmc/host/moxart-mmc.c
> +++ b/drivers/mmc/host/moxart-mmc.c
> @@ -465,9 +465,8 @@ static irqreturn_t moxart_irq(int irq, void *devid)
>  {
>         struct moxart_host *host = (struct moxart_host *)devid;
>         u32 status;
> -       unsigned long flags;
>
> -       spin_lock_irqsave(&host->lock, flags);
> +       spin_lock(&host->lock);
>
>         status = readl(host->base + REG_STATUS);
>         if (status & CARD_CHANGE) {
> @@ -484,7 +483,7 @@ static irqreturn_t moxart_irq(int irq, void *devid)
>         if (status & (FIFO_ORUN | FIFO_URUN) && host->mrq)
>                 moxart_transfer_pio(host);
>
> -       spin_unlock_irqrestore(&host->lock, flags);
> +       spin_unlock(&host->lock);
>
>         return IRQ_HANDLED;
>  }
> --
> 2.7.4
>