linux-kernel - Re: [PATCH v5 06/17] virt: acrn: Introduce VM management interfaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201105130410.GA412878@kroah.com>
Date:   Thu, 5 Nov 2020 14:04:10 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Shuo A Liu <shuo.a.liu@...el.com>
Cc:     linux-kernel@...r.kernel.org, x86@...nel.org,
        "H . Peter Anvin" <hpa@...or.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        Sean Christopherson <sean.j.christopherson@...el.com>,
        Yu Wang <yu1.wang@...el.com>,
        Reinette Chatre <reinette.chatre@...el.com>,
        Zhi Wang <zhi.a.wang@...el.com>,
        Zhenyu Wang <zhenyuw@...ux.intel.com>
Subject: Re: [PATCH v5 06/17] virt: acrn: Introduce VM management interfaces

On Thu, Nov 05, 2020 at 08:48:22PM +0800, Shuo A Liu wrote:
> > > > > Though i can
> > > > > keep some reserved fields for alignment (and to keep same data structure
> > > > > layout with the hypervisor), right?
> > > > > Documentation/driver-api/ioctl.rst says that explicit reserved fields
> > > > > could be used.
> > > >
> > > > If you need alignment, yes, that is fine, but that's not what you are
> > > > saying these are for.  And if you need alignment, why not move things
> > > > around so they are properly aligned.
> > > >
> > > > And this structure has nothing to do with the hypervisor structure,
> > > > that's a internal-kernel structure, not a userspace-visable thing if you
> > > > are doing things correctly.
> > > 
> > > It's the same structure with the one in hypervisor. HSM driver
> > > doesn't maintain the VM much, it just pass the data for VM creation from
> > > userspace to hypervisor.
> > 
> > That sounds ripe for abuse, good luck!
> 
> The hypervisor will do the sanity check. In this case, HSM driver can be
> kept simple.

Hah, good luck with the fuzzers, crashing a hypervisor will be fun for
them!

greg k-h