linux-kernel - Re: [PATCH] gpiolib: fix sysfs when cdev is not selected

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMpxmJXFsMYOVOHY8zp-C6gF9q6sfi=HuUYiSDmZBDYiJNDh3g@mail.gmail.com>
Date:   Thu, 5 Nov 2020 15:37:34 +0100
From:   Bartosz Golaszewski <bgolaszewski@...libre.com>
To:     Kent Gibson <warthog618@...il.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        linux-gpio <linux-gpio@...r.kernel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Nicolas Schichan <nschichan@...ebox.fr>
Subject: Re: [PATCH] gpiolib: fix sysfs when cdev is not selected

On Thu, Nov 5, 2020 at 11:41 AM Kent Gibson <warthog618@...il.com> wrote:
>
> In gpiochip_setup_dev() the call to gpiolib_cdev_register() indirectly
> calls device_add().  This is still required for the sysfs even when
> CONFIG_GPIO_CDEV is not selected in the build.
>
> Replace the stubbed functions in gpiolib-cdev.h with macros in gpiolib.c
> that perform the required device_add() and device_del() when
> CONFIG_GPIO_CDEV is not selected.
>
> Fixes: d143493c01b7 (gpiolib: make cdev a build option)
> Reported-by: Nicolas Schichan <nschichan@...ebox.fr>
> Signed-off-by: Kent Gibson <warthog618@...il.com>

Applied for fixes with Nicolas' tag.

Bartosz