linux-kernel - Re: [PATCH v5] mtd: spinand: micron: add support for MT29F2G01AAAED

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20201105154421.686e0675@collabora.com>
Date:   Thu, 5 Nov 2020 15:44:21 +0100
From:   Boris Brezillon <boris.brezillon@...labora.com>
To:     Thirumalesha N <nthirumalesha7@...il.com>
Cc:     Miquel Raynal <miquel.raynal@...tlin.com>,
        Richard Weinberger <richard@....at>,
        Vignesh Raghavendra <vigneshr@...com>,
        Shivamurthy Shastri <sshivamurthy@...ron.com>,
        Chuanhong Guo <gch981213@...il.com>,
        linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5] mtd: spinand: micron: add support for MT29F2G01AAAED

On Tue, 3 Nov 2020 23:18:54 +0800
Thirumalesha N <nthirumalesha7@...il.com> wrote:

> Hi Boris,
> 
> On Tue, Nov 3, 2020 at 11:03 PM Boris Brezillon <
> boris.brezillon@...labora.com> wrote:  
> 
> > On Tue,  3 Nov 2020 22:59:01 +0800
> > Thirumalesha Narasimhappa <nthirumalesha7@...il.com> wrote:
> >  
> > > The MT29F2G01AAAED is a single die, 2Gb Micron SPI NAND Flash with 4-bit
> > > ECC
> > >
> > > Signed-off-by: Thirumalesha Narasimhappa <nthirumalesha7@...il.com>
> > > ---
> > >
> > > v5: As per the review comments, the changes were reverted to the v2,
> > > except the MT29F2G01AAAED device related (including the review comments)  
> >
> > I don't think that's what Miquel suggested, especially not for the
> > {write,update,write}_cache_variants helpers.
> >  
> 
> 
> I was a bit confused with the multiple levels of comments with the previous
> patch and I renamed *{write,update,write}_cache_var**iants* to *micron_4_**
> to avoid function redefinition.
> Please can you direct me with this patch, what needs to be modified/renamed
> ?

Keep the SPINAND_OP_VARIANTS() as they were in v4 and use the micron_4_
prefix for ECC related stuff.