lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 05 Nov 2020 15:43:32 +0000 From: Marc Zyngier <maz@...nel.org> To: Daniel Palmer <daniel@...f.com> Cc: Linus Walleij <linus.walleij@...aro.org>, "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@...r.kernel.org>, linux-arm-kernel@...ts.infradead.org, Linux Kernel Mailing List <linux-kernel@...r.kernel.org> Subject: Re: [PATCH v2 3/5] gpio: msc313: MStar MSC313 GPIO driver On 2020-11-05 15:23, Daniel Palmer wrote: > Hi Marc, > > On Thu, 5 Nov 2020 at 21:08, Marc Zyngier <maz@...nel.org> wrote: >> >> On 2020-11-05 09:40, Linus Walleij wrote: >> > On Mon, Oct 19, 2020 at 4:10 PM Daniel Palmer <daniel@...f.com> wrote: >> >> [...] >> >> >> +/* The parent interrupt controller needs the GIC interrupt type set >> >> to GIC_SPI >> >> + * so we need to provide the fwspec. Essentially >> >> gpiochip_populate_parent_fwspec_twocell >> >> + * that puts GIC_SPI into the first cell. >> >> + */ >> >> nit: comment style. > > I've fixed these and some other bits for the v3. > I've held off on pushing that until the rest of it seemed right. > >> >> +static void *msc313_gpio_populate_parent_fwspec(struct gpio_chip *gc, >> >> + unsigned int >> >> parent_hwirq, >> >> + unsigned int parent_type) >> >> +{ >> >> + struct irq_fwspec *fwspec; >> >> + >> >> + fwspec = kmalloc(sizeof(*fwspec), GFP_KERNEL); >> >> + if (!fwspec) >> >> + return NULL; >> >> + >> >> + fwspec->fwnode = gc->irq.parent_domain->fwnode; >> >> + fwspec->param_count = 3; >> >> + fwspec->param[0] = GIC_SPI; >> >> + fwspec->param[1] = parent_hwirq; >> >> + fwspec->param[2] = parent_type; >> >> + >> >> + return fwspec; >> >> +} >> > >> > Clever. Looping in Marc Z so he can say if this looks allright to him. >> >> Yup, this looks correct. However, looking at the bit of the patch that >> isn't quoted here, I see that msc313_gpio_irqchip doesn't have a >> .irq_set_affinity callback. Is this system UP only? > > What is in mainline right now is UP only but there are chips with a > second cortex A7 that I have working in my tree. > So I will add that in for v3 if I can work out what I should actually > do there. :) Probably nothing more than setting the callback to irq_chip_set_affinity_parent, I'd expect. M. -- Jazz is not dead. It just smells funny...
Powered by blists - more mailing lists