linux-kernel - Re: [PATCH] kunit: fix display of failed expectations for strings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFd5g45+XbduCH4oE8dBd-uBR2MZg7-w5tf7DghqGrvMyydPUQ@mail.gmail.com>
Date:   Thu, 5 Nov 2020 08:05:51 -0800
From:   Brendan Higgins <brendanhiggins@...gle.com>
To:     Daniel Latypov <dlatypov@...gle.com>
Cc:     David Gow <davidgow@...gle.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@...r.kernel.org>,
        Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH] kunit: fix display of failed expectations for strings

On Mon, Nov 2, 2020 at 3:23 PM Daniel Latypov <dlatypov@...gle.com> wrote:
>
> Currently the following expectation
>   KUNIT_EXPECT_STREQ(test, "hi", "bye");
> will produce:
>   Expected "hi" == "bye", but
>       "hi" == 1625079497
>       "bye" == 1625079500
>
> After this patch:
>   Expected "hi" == "bye", but
>       "hi" == hi
>       "bye" == bye
>
> KUNIT_INIT_BINARY_STR_ASSERT_STRUCT() was written but just mistakenly
> not actually used by KUNIT_EXPECT_STREQ() and friends.
>
> Signed-off-by: Daniel Latypov <dlatypov@...gle.com>

Reviewed-by: Brendan Higgins <brendanhiggins@...gle.com>
Tested-by: Brendan Higgins <brendanhiggins@...gle.com>