linux-kernel - Re: [PATCH v7 01/72] KVM: SVM: nested: Don't allocate VMCB structures on stack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201105163812.GE25636@zn.tnic>
Date:   Thu, 5 Nov 2020 17:38:12 +0100
From:   Borislav Petkov <bp@...en8.de>
To:     Michael Roth <michael.roth@....com>
Cc:     Joerg Roedel <joro@...tes.org>, x86@...nel.org,
        Juergen Gross <jgross@...e.com>,
        Tom Lendacky <thomas.lendacky@....com>,
        Joerg Roedel <jroedel@...e.de>,
        Mike Stunes <mstunes@...are.com>,
        Kees Cook <keescook@...omium.org>, kvm@...r.kernel.org,
        Peter Zijlstra <peterz@...radead.org>,
        Cfir Cohen <cfir@...gle.com>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        linux-kernel@...r.kernel.org,
        Sean Christopherson <sean.j.christopherson@...el.com>,
        virtualization@...ts.linux-foundation.org,
        Martin Radev <martin.b.radev@...il.com>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Andy Lutomirski <luto@...nel.org>, hpa@...or.com,
        Erdem Aktas <erdemaktas@...gle.com>,
        David Rientjes <rientjes@...gle.com>,
        Dan Williams <dan.j.williams@...el.com>,
        Jiri Slaby <jslaby@...e.cz>
Subject: Re: [PATCH v7 01/72] KVM: SVM: nested: Don't allocate VMCB
 structures on stack

On Thu, Nov 05, 2020 at 10:24:37AM -0600, Michael Roth wrote:
> >  out_set_gif:
> >         svm_set_gif(svm, !!(kvm_state->flags & KVM_STATE_NESTED_GIF_SET));
> > -       return 0;
> > +
> > +       ret = 0;
> > +out_free:
> > +       kfree(save);
> > +       kfree(ctl);
> 
> This change seems to trigger a crash via smm-test.c (and state-test.c) KVM
> selftest when we call vcpu_load_state->KVM_SET_NESTED_STATE. I think what's
> happening is we are hitting the 'goto out_set_gif;'

No out_set_gif upstream anymore after

d5cd6f340145 ("KVM: nSVM: Avoid freeing uninitialized pointers in svm_set_nested_state()")

and it looks like you hit the issue this patch is fixing.

Can you test with the above commit cherrypicked ontop of your what looks
like 5.9.1-ish tree?

If that fixes it, we should route this patch to stable.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette