linux-kernel - Re: [v3 4/4] spi: aspeed: Add ASPEED FMC/SPI memory controller driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201105164312.GE4856@sirena.org.uk>
Date:   Thu, 5 Nov 2020 16:43:12 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Boris Brezillon <boris.brezillon@...labora.com>
Cc:     Cédric Le Goater <clg@...d.org>,
        robh+dt@...nel.org, Chin-Ting Kuo <chin-ting_kuo@...eedtech.com>,
        joel@....id.au, andrew@...id.au, bbrezillon@...nel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-aspeed@...ts.ozlabs.org, linux-spi@...r.kernel.org,
        BMC-SW@...eedtech.com
Subject: Re: [v3 4/4] spi: aspeed: Add ASPEED FMC/SPI memory controller driver

On Thu, Nov 05, 2020 at 04:11:32PM +0100, Boris Brezillon wrote:
> Cédric Le Goater <clg@...d.org> wrote:

> > Thanks for this driver. It's much cleaner than the previous and we should 
> > try adding support for the AST2500 SoC also. I guess we can keep the old 
> > driver for the AST2400 which has a different register layout.
> > 
> > On the patchset, I think we should split this patch in three : 
> > 
> >  - basic support
> >  - AHB window calculation depending on the flash size
> >  - read training support  

> I didn't look closely at the implementation, but if the read training
> tries to read a section of the NOR, I'd recommend exposing that feature
> through spi-mem and letting the SPI-NOR framework trigger the training
> instead of doing that at dirmap creation time (remember that spi-mem is
> also used for SPI NANDs which use the dirmap API too, and this training
> is unlikely to work there).

> The SPI-NOR framework could pass a read op template and a reference
> pattern such that all the spi-mem driver has to do is execute the
> template op and compare the output to the reference buffer.

That seems like a good idea.

> > We should avoid magic values when setting registers. This is confusing 
> > and defines are much better.

It does depend a bit on documentation though, it's not a hard
requirement.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)