linux-kernel - Re: [PATCH v4 0/5] Unify NUMA implementation between ARM64 & RISC-V

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201106171818.GL29329@gaia>
Date:   Fri, 6 Nov 2020 17:18:19 +0000
From:   Catalin Marinas <catalin.marinas@....com>
To:     Palmer Dabbelt <palmer@...belt.com>
Cc:     Atish Patra <Atish.Patra@....com>,
        Will Deacon <willdeacon@...gle.com>, maz@...nel.org,
        linux-kernel@...r.kernel.org, Jonathan.Cameron@...wei.com,
        aou@...s.berkeley.edu, akpm@...ux-foundation.org,
        anshuman.khandual@....com, anup@...infault.org,
        Arnd Bergmann <arnd@...db.de>, david@...hat.com,
        greentime.hu@...ive.com, Greg KH <gregkh@...uxfoundation.org>,
        justin.he@....com, wangkefeng.wang@...wei.com,
        linux-arch@...r.kernel.org, linux-riscv@...ts.infradead.org,
        rppt@...nel.org, nsaenzjulienne@...e.de,
        Paul Walmsley <paul.walmsley@...ive.com>, rafael@...nel.org,
        steven.price@....com, will@...nel.org, zong.li@...ive.com,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v4 0/5] Unify NUMA implementation between ARM64 & RISC-V

On Thu, Nov 05, 2020 at 10:07:00AM -0800, Palmer Dabbelt wrote:
> On Mon, 05 Oct 2020 17:17:47 PDT (-0700), Atish Patra wrote:
> > arch/arm64/Kconfig                            |  1 +
> > arch/arm64/include/asm/numa.h                 | 45 +----------------
> > arch/arm64/kernel/acpi_numa.c                 | 13 -----
> > arch/arm64/mm/Makefile                        |  1 -
> > arch/arm64/mm/init.c                          |  4 +-
> > arch/riscv/Kconfig                            | 31 +++++++++++-
> > arch/riscv/include/asm/mmzone.h               | 13 +++++
> > arch/riscv/include/asm/numa.h                 |  8 +++
> > arch/riscv/include/asm/pci.h                  | 14 ++++++
> > arch/riscv/include/asm/pgtable.h              | 21 ++++++++
> > arch/riscv/kernel/setup.c                     | 11 ++++-
> > arch/riscv/kernel/smpboot.c                   | 12 ++++-
> > arch/riscv/mm/init.c                          | 10 +++-
> > drivers/base/Kconfig                          |  6 +++
> > drivers/base/Makefile                         |  1 +
> > .../mm/numa.c => drivers/base/arch_numa.c     | 30 ++++++++++--
> > include/asm-generic/numa.h                    | 49 +++++++++++++++++++
> > 17 files changed, 199 insertions(+), 71 deletions(-)
> > create mode 100644 arch/riscv/include/asm/mmzone.h
> > create mode 100644 arch/riscv/include/asm/numa.h
> > rename arch/arm64/mm/numa.c => drivers/base/arch_numa.c (95%)
> > create mode 100644 include/asm-generic/numa.h
[...]
> arm64 guys: do you want to try and do some sort of shared base tag sort of
> thing for these, or do you want me to refactor this such that it adds the
> generic stuff before removing the arm64 stuff so we can decouble that way?

I had a comment on the second patch (probably impacting the first) but
otherwise they look fine.

I'm happy for this series to go in via the riscv tree but, if we run
into conflicts, please provide a stable branch somewhere containing the
arm64 changes (first two patches).

-- 
Catalin