[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20201106191147.GY3249@paulmck-ThinkPad-P72>
Date: Fri, 6 Nov 2020 11:11:47 -0800
From: "Paul E. McKenney" <paulmck@...nel.org>
To: Alan Stern <stern@...land.harvard.edu>
Cc: linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org,
kernel-team@...com, mingo@...nel.org, parri.andrea@...il.com,
will@...nel.org, peterz@...radead.org, boqun.feng@...il.com,
npiggin@...il.com, dhowells@...hat.com, j.alglave@....ac.uk,
luc.maranget@...ia.fr, akiyks@...il.com
Subject: Re: [PATCH memory-model 3/8] tools/memory-model: Document categories
of ordering primitives
On Fri, Nov 06, 2020 at 11:56:54AM -0500, Alan Stern wrote:
> On Thu, Nov 05, 2020 at 02:00:12PM -0800, paulmck@...nel.org wrote:
> > From: "Paul E. McKenney" <paulmck@...nel.org>
> >
> > The Linux kernel has a number of categories of ordering primitives, which
> > are recorded in the LKMM implementation and hinted at by cheatsheet.txt.
> > But there is no overview of these categories, and such an overview
> > is needed in order to understand multithreaded LKMM litmus tests.
> > This commit therefore adds an ordering.txt as well as extracting a
> > control-dependencies.txt from memory-barriers.txt. It also updates the
> > README file.
> >
> > [ paulmck: Apply Akira Yokosawa file-placement feedback. ]
> > [ paulmck: Apply Alan Stern feedback. ]
> > [ paulmck: Apply self-review feedback. ]
> > Signed-off-by: Paul E. McKenney <paulmck@...nel.org>
> > ---
> > diff --git a/tools/memory-model/Documentation/README b/tools/memory-model/Documentation/README
> > index 2d9539f..a50ea81 100644
> > --- a/tools/memory-model/Documentation/README
> > +++ b/tools/memory-model/Documentation/README
>
> > @@ -41,13 +50,21 @@ README
> > cheatsheet.txt
> > Quick-reference guide to the Linux-kernel memory model.
> >
> > +control-dependencies.txt
> > + Guide to preventing compiler optimizations from destroying
> > + your control dependencies.
> > +
> > explanation.txt
> > - Detailed description of the memory model.
> > + Detailed description of the memory model in detail.
>
> A redundantly redundant change.
I will revert the reversion of the removal of the added detail "in
detail". ;-)
Good catch, thank you!
Thanx, Paul
Powered by blists - more mailing lists