linux-kernel - Re: [Sound-open-firmware] linux-next: Tree for Nov 6 (sound/soc/sof/sof-pci-dev.o)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7505ed68-f12b-d1d9-12e5-f8ae34a74ebd@linux.intel.com>
Date:   Fri, 6 Nov 2020 14:53:38 -0600
From:   Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
To:     Randy Dunlap <rdunlap@...radead.org>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        Linux Next Mailing List <linux-next@...r.kernel.org>
Cc:     Kai Vehmanen <kai.vehmanen@...ux.intel.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Ranjani Sridharan <ranjani.sridharan@...ux.intel.com>,
        Daniel Baluta <daniel.baluta@....com>,
        sound-open-firmware@...a-project.org,
        "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." 
        <alsa-devel@...a-project.org>
Subject: Re: [Sound-open-firmware] linux-next: Tree for Nov 6
 (sound/soc/sof/sof-pci-dev.o)


> on x86_64:
> 
> ld: sound/soc/sof/sof-pci-dev.o: in function `sof_pci_probe':
> sof-pci-dev.c:(.text+0x5c): undefined reference to `snd_intel_dsp_driver_probe'
> 
> 
> Full randconfig file is attached.

Nice catch, thanks Randy! Looks like we put the select 
SND_INTEL_DSP_CONFIG in the wrong place, it's not dependent on the 
HDaudio link being selected. Clearly a bug we've had for a while.

The diff below makes the error go away but I have to run it past folks 
who are already enjoying their week-end. Will follow-up next week with a 
proper fix.

diff --git a/sound/soc/sof/intel/Kconfig b/sound/soc/sof/intel/Kconfig
index a066e08860cb..5bfc2f8b13b9 100644
--- a/sound/soc/sof/intel/Kconfig
+++ b/sound/soc/sof/intel/Kconfig
@@ -271,6 +271,7 @@ config SND_SOC_SOF_JASPERLAKE

  config SND_SOC_SOF_HDA_COMMON
         tristate
+       select SND_INTEL_DSP_CONFIG
         select SND_SOC_SOF_INTEL_COMMON
         select SND_SOC_SOF_HDA_LINK_BASELINE
         help
@@ -330,7 +331,6 @@ config SND_SOC_SOF_HDA
         tristate
         select SND_HDA_EXT_CORE if SND_SOC_SOF_HDA_LINK
         select SND_SOC_HDAC_HDA if SND_SOC_SOF_HDA_AUDIO_CODEC
-       select SND_INTEL_DSP_CONFIG
         help
           This option is not user-selectable but automagically handled by
           'select' statements at a higher level