linux-kernel - Re: [PATCH v2 net-next 06/13] octeontx2-pf: Add support for unicast MAC address filtering

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <df7273e41c72d0b9ac3e7df2773417069169a29f.camel@kernel.org>
Date:   Fri, 06 Nov 2020 14:15:33 -0800
From:   Saeed Mahameed <saeed@...nel.org>
To:     Naveen Mamindlapalli <naveenm@...vell.com>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     kuba@...nel.org, davem@...emloft.net, sgoutham@...vell.com,
        lcherian@...vell.com, gakula@...vell.com, jerinj@...vell.com,
        sbhatta@...vell.com, hkelam@...vell.com
Subject: Re: [PATCH v2 net-next 06/13] octeontx2-pf: Add support for unicast
 MAC address filtering

On Thu, 2020-11-05 at 14:58 +0530, Naveen Mamindlapalli wrote:
> From: Hariprasad Kelam <hkelam@...vell.com>
> 
> Add unicast MAC address filtering support using install flow
> message. Total of 8 MCAM entries are allocated for adding
> unicast mac filtering rules. If the MCAM allocation fails,
> the unicast filtering support will not be advertised.
> 
> Signed-off-by: Hariprasad Kelam <hkelam@...vell.com>
> Signed-off-by: Sunil Goutham <sgoutham@...vell.com>
> Signed-off-by: Naveen Mamindlapalli <naveenm@...vell.com>
> ---
>  .../ethernet/marvell/octeontx2/nic/otx2_common.h   |  10 ++
>  .../ethernet/marvell/octeontx2/nic/otx2_flows.c    | 138
> +++++++++++++++++++--
>  .../net/ethernet/marvell/octeontx2/nic/otx2_pf.c   |   5 +
>  3 files changed, 146 insertions(+), 7 deletions(-)
> 

> +int otx2_add_macfilter(struct net_device *netdev, const u8 *mac)
> +{
> +	struct otx2_nic *pf = netdev_priv(netdev);
> +	int err;
> +
> +	err = otx2_do_add_macfilter(pf, mac);
> +	if (err) {
> +		netdev->flags |= IFF_PROMISC;

I don't think you are allowed to change netdev->flags inside the driver
like this, this can easily conflict with other users of this netdev;
netdev promiscuity is managed by the stack via refcount Please see:
__dev_set_promiscuity() and dev_set_promiscuity()

And you will need to notify stack and userspace of flags changes.