[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <1604629881-557-1-git-send-email-wangqing@vivo.com>
Date: Fri, 6 Nov 2020 10:31:19 +0800
From: Wang Qing <wangqing@...o.com>
To: Rob Clark <robdclark@...il.com>, Sean Paul <sean@...rly.run>,
David Airlie <airlied@...ux.ie>,
Daniel Vetter <daniel@...ll.ch>,
Jordan Crouse <jcrouse@...eaurora.org>,
Jonathan Marek <jonathan@...ek.ca>,
Akhil P Oommen <akhilpo@...eaurora.org>,
Sharat Masetty <smasetty@...eaurora.org>,
linux-arm-msm@...r.kernel.org, dri-devel@...ts.freedesktop.org,
freedreno@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Cc: Wang Qing <wangqing@...o.com>
Subject: [PATCH] drm: Use IS_ERR() instead of null pointer check
a6xx_gmu_get_mmio() never return null in case of error, but ERR_PTR(),
so we should use IS_ERR() instead of null pointer check
Signed-off-by: Wang Qing <wangqing@...o.com>
---
drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
index 491fee4..8c81a89
--- a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
+++ b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
@@ -492,7 +492,7 @@ static void a6xx_gmu_rpmh_init(struct a6xx_gmu *gmu)
void __iomem *seqptr = a6xx_gmu_get_mmio(pdev, "gmu_pdc_seq");
uint32_t pdc_address_offset;
- if (!pdcptr || !seqptr)
+ if (IS_ERR(pdcptr) || IS_ERR(seqptr))
goto err;
if (adreno_is_a618(adreno_gpu) || adreno_is_a640(adreno_gpu))
--
2.7.4
Powered by blists - more mailing lists