linux-kernel - [PATCH] lib/zstd: remove unused macro tame compiler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Fri,  6 Nov 2020 10:56:08 +0800
From:   Alex Shi <alex.shi@...ux.alibaba.com>
To:     unlisted-recipients:; (no To-header on input)
Cc:     Nick Terrell <terrelln@...com>, Kees Cook <keescook@...omium.org>,
        Ingo Molnar <mingo@...nel.org>, linux-kernel@...r.kernel.org
Subject: [PATCH] lib/zstd: remove unused macro tame compiler

There are some of unused macros cause compiler warning, let's remove them.

lib/zstd/fse_compress.c:82:0: warning: macro "FSE_FUNCTION_NAME" is not used [-Wunused-macros]
lib/zstd/fse_decompress.c:90:0: warning: macro "FSE_FUNCTION_NAME" is not used [-Wunused-macros]
lib/zstd/fse_compress.c:82:0: warning: macro "FSE_FUNCTION_NAME" is not used [-Wunused-macros]
lib/zstd/fse_decompress.c:90:0: warning: macro "FSE_FUNCTION_NAME" is not used [-Wunused-macros]
lib/zstd/fse_compress.c:83:0: warning: macro "FSE_TYPE_NAME" is not used [-Wunused-macros]
lib/zstd/fse_decompress.c:91:0: warning: macro "FSE_TYPE_NAME" is not used [-Wunused-macros]
lib/zstd/fse_compress.c:83:0: warning: macro "FSE_TYPE_NAME" is not used [-Wunused-macros]
lib/zstd/fse_decompress.c:91:0: warning: macro "FSE_TYPE_NAME" is not used [-Wunused-macros]
lib/zstd/fse_compress.c:81:0: warning: macro "FSE_CAT" is not used [-Wunused-macros]
lib/zstd/fse_decompress.c:89:0: warning: macro "FSE_CAT" is not used [-Wunused-macros]
lib/zstd/fse_compress.c:81:0: warning: macro "FSE_CAT" is not used [-Wunused-macros]
lib/zstd/fse_decompress.c:89:0: warning: macro "FSE_CAT" is not used [-Wunused-macros]

Signed-off-by: Alex Shi <alex.shi@...ux.alibaba.com>
Cc: Nick Terrell <terrelln@...com> 
Cc: Kees Cook <keescook@...omium.org> 
Cc: Ingo Molnar <mingo@...nel.org> 
Cc: linux-kernel@...r.kernel.org 
---
 lib/zstd/fse_compress.c   | 5 -----
 lib/zstd/fse_decompress.c | 5 -----
 2 files changed, 10 deletions(-)

diff --git a/lib/zstd/fse_compress.c b/lib/zstd/fse_compress.c
index ef3d1741d532..20367cd2eaa0 100644
--- a/lib/zstd/fse_compress.c
+++ b/lib/zstd/fse_compress.c
@@ -77,11 +77,6 @@
 #error "FSE_FUNCTION_TYPE must be defined"
 #endif
 
-/* Function names */
-#define FSE_CAT(X, Y) X##Y
-#define FSE_FUNCTION_NAME(X, Y) FSE_CAT(X, Y)
-#define FSE_TYPE_NAME(X, Y) FSE_CAT(X, Y)
-
 /* Function templates */
 
 /* FSE_buildCTable_wksp() :
diff --git a/lib/zstd/fse_decompress.c b/lib/zstd/fse_decompress.c
index 0b353530fb3f..86fff64db563 100644
--- a/lib/zstd/fse_decompress.c
+++ b/lib/zstd/fse_decompress.c
@@ -78,11 +78,6 @@
 #error "FSE_FUNCTION_TYPE must be defined"
 #endif
 
-/* Function names */
-#define FSE_CAT(X, Y) X##Y
-#define FSE_FUNCTION_NAME(X, Y) FSE_CAT(X, Y)
-#define FSE_TYPE_NAME(X, Y) FSE_CAT(X, Y)
-
 /* Function templates */
 
 size_t FSE_buildDTable_wksp(FSE_DTable *dt, const short *normalizedCounter, unsigned maxSymbolValue, unsigned tableLog, void *workspace, size_t workspaceSize)
-- 
1.8.3.1