linux-kernel - Re: [PATCH] perf vendor events: Update Skylake client events to v50

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <93fae76f-ce2b-ab0b-3ae9-cc9a2b4cbaec@linux.intel.com>
Date:   Fri, 6 Nov 2020 11:11:59 +0800
From:   "Jin, Yao" <yao.jin@...ux.intel.com>
To:     Namhyung Kim <namhyung@...nel.org>
Cc:     acme@...nel.org, jolsa@...nel.org, peterz@...radead.org,
        mingo@...hat.com, alexander.shishkin@...ux.intel.com,
        Linux-kernel@...r.kernel.org, ak@...ux.intel.com,
        kan.liang@...el.com, yao.jin@...el.com, irogers@...gle.com
Subject: Re: [PATCH] perf vendor events: Update Skylake client events to v50

Hi Namhyung,

On 11/6/2020 11:00 AM, Namhyung Kim wrote:
> Hi,
> 
> On Wed, Nov 04, 2020 at 09:51:02AM +0800, Jin Yao wrote:
>> - Update Skylake events to v50.
>> - Update Skylake JSON metrics from TMAM 4.0.
>> - Fix the issue in DRAM_Parallel_Reads
>> - Fix the perf test warning
>>
>> Before:
>>
>> root@...-ppc:~# perf stat -M DRAM_Parallel_Reads -- sleep 1
>> event syntax error: '{arb/event=0x80,umask=0x2/,arb/event=0x80,umask=0x2,thresh=1/}:W'
>>                       \___ unknown term 'thresh' for pmu 'uncore_arb'
>>
>> valid terms: event,edge,inv,umask,cmask,config,config1,config2,name,period,percore
>>
>> Initial error:
>> event syntax error: '..umask=0x2/,arb/event=0x80,umask=0x2,thresh=1/}:W'
>>                                    \___ Cannot find PMU `arb'. Missing kernel support?
>>
>> root@...-ppc:~# perf test metrics
>> 10: PMU events                                 :
>> 10.3: Parsing of PMU event table metrics               : Skip (some metrics failed)
>> 10.4: Parsing of PMU event table metrics with fake PMUs: Ok
>> 67: Parse and process metrics                  : Ok
>>
>> After:
>>
>> root@...-ppc:~# perf stat -M MEM_Parallel_Reads -- sleep 1
>>
>>   Performance counter stats for 'system wide':
>>
>>           4,951,646      arb/event=0x80,umask=0x2/ #    26.30 MEM_Parallel_Reads       (50.04%)
>>             188,251      arb/event=0x80,umask=0x2,cmask=1/                                     (49.96%)
>>
>>         1.000867010 seconds time elapsed
>>
>> root@...-ppc:~# perf test metrics
>> 10: PMU events                                 :
>> 10.3: Parsing of PMU event table metrics               : Ok
>> 10.4: Parsing of PMU event table metrics with fake PMUs: Ok
>> 67: Parse and process metrics                  : Ok
>>
>> Signed-off-by: Jin Yao <yao.jin@...ux.intel.com>
> 
> It seems not applied to acme/perf/core cleanly.
> 
> Thanks,
> Namhyung
> 

It seems the patch mail is truncated. :(

I attach the patch file in the mail. Sorry for inconvenience.

Thanks
Jin Yao



View attachment "0001-perf-vendor-events-Update-Skylake-client-events-to-v.patch" of type "text/plain" (568519 bytes)