linux-kernel - Re: [PATCH v2] serial: txx9: add missing platform_driver_unregister() on error in serial_txx9

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7c860bb7-d587-59b6-f4e3-02c9e497244a@huawei.com>
Date:   Fri, 6 Nov 2020 11:19:52 +0800
From:   Qinglang Miao <miaoqinglang@...wei.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:     Jiri Slaby <jirislaby@...nel.org>, <linux-serial@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] serial: txx9: add missing platform_driver_unregister()
 on error in serial_txx9_init



在 2020/11/3 15:45, Greg Kroah-Hartman 写道:
> On Tue, Nov 03, 2020 at 03:33:41PM +0800, Qinglang Miao wrote:
>> Add the missing platform_driver_unregister() before return
>> from serial_txx9_init in the error handling case when failed
>> to register serial_txx9_pci_driver with macro ENABLE_SERIAL_TXX9_PCI
>> defined.
>>
>> Fixes: ab4382d27412 ("tty: move drivers/serial/ to drivers/tty/serial/")
>> Signed-off-by: Qinglang Miao <miaoqinglang@...wei.com>
>> ---
>>   drivers/tty/serial/serial_txx9.c | 3 +++
>>   1 file changed, 3 insertions(+)
> 
> What changed from v1?  Always put that below the --- line.
> 
> Please fix up and send v3.
> 
> thanks,
> 
> greg k-h
> .
Hi Greg,

Sorry about that. I've resent a new v3 patch showing the changes.

Thanks.
>