lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 6 Nov 2020 11:31:18 +0800 From: Wang Qing <wangqing@...o.com> To: Felipe Balbi <balbi@...nel.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org Cc: Wang Qing <wangqing@...o.com> Subject: [PATCH] usb: Use IS_ERR_OR_NULL() instead of IS_ERR() __usb_find_phy may return NULL, so we should use IS_ERR_OR_NULL() Signed-off-by: Wang Qing <wangqing@...o.com> --- drivers/usb/phy/phy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/phy/phy.c b/drivers/usb/phy/phy.c index de21967..60c5ea4 100755 --- a/drivers/usb/phy/phy.c +++ b/drivers/usb/phy/phy.c @@ -460,7 +460,7 @@ struct usb_phy *usb_get_phy(enum usb_phy_type type) spin_lock_irqsave(&phy_lock, flags); phy = __usb_find_phy(&phy_list, type); - if (IS_ERR(phy) || !try_module_get(phy->dev->driver->owner)) { + if (IS_ERR_OR_NULL(phy) || !try_module_get(phy->dev->driver->owner)) { pr_debug("PHY: unable to find transceiver of type %s\n", usb_phy_type_string(type)); if (!IS_ERR(phy)) -- 2.7.4
Powered by blists - more mailing lists